From: Kuniyuki Iwashima <kuniyu@google.com>
To: przemyslaw.kitszel@intel.com
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
kuniyu@google.com
Subject: Re: [RFC] Solution how to split a file in a way that git blame looks fine
Date: Tue, 15 Jul 2025 22:05:39 +0000 [thread overview]
Message-ID: <20250715220654.1337102-1-kuniyu@google.com> (raw)
In-Reply-To: <5b94d14e-a0e7-47bd-82fc-c85171cbf26e@intel.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date: Tue, 15 Jul 2025 22:33:40 +0200
> Hi,
>
> I have developed (or discovered ;)) how to split a file in a way that
> both old and new are nice in terms of git-blame
>
> https://github.com/pkitszel/linux/commits/virtchnl-split/
>
> The purpose of RFC is to ask if anyone is in strong disagreement with me
>
> There is more commits needed to have it nice, so it forms a git-log vs
> git-blame tradeoff, but (after the brief moment that this is on the top)
> we spend orders of magnitude more time looking at the blame output (and
> commit messages linked from that) - so I find it much better to see
> actual logic changes instead of "move xx to yy" stuff (typical for
> "squashed/single-commit splits").
FWIW, git-blame has -M/C to track X-times line moves within/across files.
>
> Cherry-picks/rebases work the same with this method as with simple
> "squashed/single-commit" approach (literally all commits squashed into
> one (to have better git-log, but shitty git-blame output).
>
> Rationale for the split itself is, as usual, "file is big and we want to
> extend it".
>
next prev parent reply other threads:[~2025-07-15 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 20:33 [RFC] Solution how to split a file in a way that git blame looks fine Przemek Kitszel
2025-07-15 22:05 ` Kuniyuki Iwashima [this message]
2025-07-16 7:47 ` Przemek Kitszel
2025-07-16 15:49 ` [Intel-wired-lan] " Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715220654.1337102-1-kuniyu@google.com \
--to=kuniyu@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox