From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay15.mail.gandi.net (relay15.mail.gandi.net [217.70.178.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D7FD28751D for ; Wed, 16 Jul 2025 07:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.178.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752650769; cv=none; b=bLck+PJFv9vstuDa1ikXIzXJblfbX9c9Esa6GYq/Py6EzdjD1UJqpsuQ4EZBgzt5dRSrU2JF1uo+tXJJEB4aAA5rEwgiT+3wALplptWZ73ehvKrJ0ZfBtAj/pm6DBT6Qo4Nyo2FudBzf2B++ndBdtaxFt2LzTlkF2CgkZF2QeYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752650769; c=relaxed/simple; bh=sAycwssUPp6qdBMnJNLVjwhs/goAFY21oqlFroIZZZw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cip1LhI2bRh9mLD9INOsrdVQfe3fFnmm+lCkx+RHOnHfzd7SoVGpSqOoFcn65kH0bsd/2f62lgvSExRmajdMmDw9EDJj1iU7h55kyi+Iy4T18UnSHtVTG6De3+YEiX9en3ANHbk1rHTW27XKV5vdLLxiVDanUOtcnm8M5tbco/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=NMckRudW; arc=none smtp.client-ip=217.70.178.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="NMckRudW" Received: by mail.gandi.net (Postfix) with ESMTPSA id E53AA442AB; Wed, 16 Jul 2025 07:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1752650759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DiiXnkuJtQ8VDaCurAgF8ESO9npD6vbbxWPC/5BE7K8=; b=NMckRudWQnSiLp5fox7XBfPyLf3OK6W1/qemLR4oYt5GRqqZv4oW0vfkhSkfp1+ujGlWnm GmlcPR1KGtF5Q2oYgKzxNRkdajp5gMeL0XrF1ltqgiL0KFX014EvcqaORxehDgQt1zzBK4 kvymlZrKWVWYt22I1XiqiXQlWGBUNU1geyTZzvpSMvOsZgRXoRj1qFl9WbSm1PAZaSVqVd KI94c3LxRyXZU7SmBHWGh6/PRFtrFe49z9uVJUYhC7GzHxCcxBZhZM6YhLk7Trj6A2DAdQ xqN4JaExdBtp2xROrwSq49nDvE+iL6tq83lYT+KPKyPW3zP15pbQwfj0wRPMrQ== Date: Wed, 16 Jul 2025 09:25:57 +0200 From: Maxime Chevallier To: Jack Ping CHNG Cc: , , , , Subject: Re: [PATCH net-next] net: pcs: xpcs: mask readl() return value to 16 bits Message-ID: <20250716092557.09bc8781@fedora.home> In-Reply-To: <20250716030349.3796806-1-jchng@maxlinear.com> References: <20250716030349.3796806-1-jchng@maxlinear.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdehjedutdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfohfogggtgfesthejredtredtvdenucfhrhhomhepofgrgihimhgvucevhhgvvhgrlhhlihgvrhcuoehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeegveeltddvveeuhefhvefhlefhkeevfedtgfeiudefffeiledttdfgfeeuhfeukeenucfkphepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejpdhhvghlohepfhgvughorhgrrdhhohhmvgdpmhgrihhlfhhrohhmpehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeeipdhrtghpthhtohepjhgthhhnghesmhgrgihlihhnvggrrhdrtghomhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtp dhrtghpthhtohepfhgrnhgtvghrrdhlrghntggvrhesghhmrghilhdrtghomhdprhgtphhtthhopeihiihhuhesmhgrgihlihhnvggrrhdrtghomhdprhgtphhtthhopehsuhhrvghshhhnrghgrghrrghjsehmrgiglhhinhgvrghrrdgtohhm Hi Jack, On Wed, 16 Jul 2025 11:03:49 +0800 Jack Ping CHNG wrote: > readl() returns 32-bit value but Clause 22/45 registers are 16-bit wide. > Masking with 0xFFFF avoids using garbage upper bits. > > Signed-off-by: Jack Ping CHNG I'm OK with the patch, but is it fixing an issue you've seen in real life ? If so, you should make this a fix, sent to -net with a Fixes tag. If not, Reviewed-by: Maxime Chevallier Maxime