From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com,
sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, joe@dama.to,
willemdebruijn.kernel@gmail.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v2] xsk: skip validating skb list in xmit path
Date: Wed, 16 Jul 2025 16:43:12 -0700 [thread overview]
Message-ID: <20250716164312.40a18d2f@kernel.org> (raw)
In-Reply-To: <CAL+tcoByyPQX+L3bbAg1hC4YLbnuPrLKidgqKqbyoj0Sny7mxQ@mail.gmail.com>
On Thu, 17 Jul 2025 07:37:42 +0800 Jason Xing wrote:
> On Thu, Jul 17, 2025 at 5:56 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Wed, 16 Jul 2025 20:27:25 +0800 Jason Xing wrote:
> > > This patch only does one thing that removes validate_xmit_skb_list()
> > > for xsk.
> >
> > Please no, I understand that it's fun to optimize the fallback paths
> > but it increases the complexity of the stack.
>
> Are you suggesting to remove this description? And I see you marked it
> as 'rejected', so it seems that I should use the V1 patch which
> doesn't increase the complexity.
No, I'm questioning optimizing the copy mode AF_XDP in the first place.
next prev parent reply other threads:[~2025-07-16 23:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 12:27 [PATCH net-next v2] xsk: skip validating skb list in xmit path Jason Xing
2025-07-16 21:42 ` Stanislav Fomichev
2025-07-16 21:56 ` Jakub Kicinski
2025-07-16 23:37 ` Jason Xing
2025-07-16 23:43 ` Jakub Kicinski [this message]
2025-07-17 0:06 ` Jason Xing
2025-07-17 0:52 ` Jakub Kicinski
2025-07-17 1:12 ` Jason Xing
2025-07-17 2:52 ` Willem de Bruijn
2025-07-17 3:10 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716164312.40a18d2f@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=joe@dama.to \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).