From: Jakub Kicinski <kuba@kernel.org>
To: William Liu <will@willsroot.io>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, pabeni@redhat.com,
savy@syst3mfailure.io, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, horms@kernel.org
Subject: Re: [PATCH net 2/2] selftests/tc-testing: Test htb_dequeue_tree with deactivation and row emptying
Date: Wed, 16 Jul 2025 16:53:18 -0700 [thread overview]
Message-ID: <20250716165318.3218679f@kernel.org> (raw)
In-Reply-To: <20250714031413.76259-1-will@willsroot.io>
On Mon, 14 Jul 2025 03:14:25 +0000 William Liu wrote:
> Ensure that any deactivation and row emptying that occurs
> during htb_dequeue_tree does not cause a kernel panic.
> This scenario originally triggered a kernel BUG_ON, and
> we are checking for a graceful fail now.
The test doesn't apply anymore, could you respin?
Perhaps try to add the testcase somewhere in the middle rather than
at the end, maybe next to an existing HTB or netem test?
--
pw-bot: cr
prev parent reply other threads:[~2025-07-16 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 3:12 [PATCH net 1/2] net/sched: Return NULL when htb_lookup_leaf encounters an empty rbtree William Liu
2025-07-14 3:14 ` [PATCH net 2/2] selftests/tc-testing: Test htb_dequeue_tree with deactivation and row emptying William Liu
2025-07-16 23:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716165318.3218679f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=savy@syst3mfailure.io \
--cc=will@willsroot.io \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).