From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F01A1DF26B; Wed, 16 Jul 2025 05:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752642599; cv=none; b=sdH6whosOfn1yLzbPHyU15v9iM33rOvMoKgcGHE7KO623RwxsqxdoGIHvpB1hHzHAtLtnfNOghEfXoHqa82kay3nODqXKunvpLA/RmriXW93Cc4DCRM/5bhsgbNXWSHwoKlg1rgD9vxQgTNaIKHpGaKhdi8gGAlESlAQ/GS9PnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752642599; c=relaxed/simple; bh=cOqdqIUO7fxmsC4oJLZT5RjBxfuL037AGc3yeM3iP/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lcSsJu+gXusLs4sBbkEpqcxb37WhttvZdm1evmXHcckN8UHro2MRHM9ATxpM/8zgfrPtVFSj0rLwJfjln2FCqvT0JtH6bdUuZ1yHQBEtjNd+AGElNYwXmj31aRH1JpsigxmBBimgo/DtyEIqMTK2QHlyZiEtSeXtWplsweHY5e0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=u6wJDG2q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="u6wJDG2q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B5A9C4CEF0; Wed, 16 Jul 2025 05:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752642598; bh=cOqdqIUO7fxmsC4oJLZT5RjBxfuL037AGc3yeM3iP/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u6wJDG2qJ9PFcVAuQRvzw4syFpfe12yzoyafiri8z/8PLrxjmgN5PWVZN9zrFFwFU qsAn2LaSYuEw5pbSn4RLfMv0isxRHjK4cep5eBorAgYFkvTTRQ0XrB6zCMCaS5RnYE axk7qMx/nxk7a8zcUGh7uVTJxDRtHvU+jRCX+8Dc= Date: Wed, 16 Jul 2025 07:09:55 +0200 From: Greg Kroah-Hartman To: Sean Anderson Cc: Radhey Shyam Pandey , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Dave Ertman , Saravana Kannan , Leon Romanovsky , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, Ira Weiny Subject: Re: [PATCH net v2 1/4] auxiliary: Support hexadecimal ids Message-ID: <2025071637-doubling-subject-25de@gregkh> References: <20250716000110.2267189-1-sean.anderson@linux.dev> <20250716000110.2267189-2-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250716000110.2267189-2-sean.anderson@linux.dev> On Tue, Jul 15, 2025 at 08:01:07PM -0400, Sean Anderson wrote: > Support creating auxiliary devices with the id included as part of the > name. This allows for hexadecimal ids, which may be more appropriate for > auxiliary devices created as children of memory-mapped devices. If an > auxiliary device's id is set to AUXILIARY_DEVID_NONE, the name must > be of the form "name.id". > > With this patch, dmesg logs from an auxiliary device might look something > like > > [ 4.781268] xilinx_axienet 80200000.ethernet: autodetected 64-bit DMA range > [ 21.889563] xilinx_emac.mac xilinx_emac.mac.80200000 net4: renamed from eth0 > [ 32.296965] xilinx_emac.mac xilinx_emac.mac.80200000 net4: PHY [axienet-80200000:05] driver [RTL8211F Gigabit Ethernet] (irq=70) > [ 32.313456] xilinx_emac.mac xilinx_emac.mac.80200000 net4: configuring for inband/sgmii link mode > [ 65.095419] xilinx_emac.mac xilinx_emac.mac.80200000 net4: Link is Up - 1Gbps/Full - flow control rx/tx > > this is especially useful when compared to what might happen if there is > an error before userspace has the chance to assign a name to the netdev: > > [ 4.947215] xilinx_emac.mac xilinx_emac.mac.1 (unnamed net_device) (uninitialized): incorrect link mode for in-band status > > Signed-off-by: Sean Anderson > --- > > Changes in v2: > - Add example log output to commit message I rejected v1, why is this being sent again? confused, greg k-h