From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
andrew@lunn.ch, donald.hunter@gmail.com, shuah@kernel.org,
kory.maincent@bootlin.com, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next 6/8] ethtool: rss: support creating contexts via Netlink
Date: Mon, 21 Jul 2025 08:21:11 -0700 [thread overview]
Message-ID: <20250721082111.6826d138@kernel.org> (raw)
In-Reply-To: <70db339e-a60b-430c-bc8e-f226decb44f7@nvidia.com>
On Sun, 20 Jul 2025 14:42:36 +0300 Gal Pressman wrote:
> On 18/07/2025 2:43, Jakub Kicinski wrote:
> > +Kernel response contents:
> > +
> > +===================================== ====== ==============================
> > + ``ETHTOOL_A_RSS_HEADER`` nested request header
> > + ``ETHTOOL_A_RSS_CONTEXT`` u32 context number
> > +===================================== ====== ==============================
> > +
> > +Create an additional RSS context, if ``ETHTOOL_A_RSS_CONTEXT`` is not
> > +specified kernel will allocate one automatically.
>
> We don't support choosing the context id from userspace in ioctl flow, I
> think it should be stated somewhere (at the least, in the commit message?).
Sure, how about:
Support letting user choose the ID for the new context. This was not
possible in IOCTL since the context ID field for the create action had
to be set to the ETH_RXFH_CONTEXT_ALLOC magic value.
next prev parent reply other threads:[~2025-07-21 15:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 23:43 [PATCH net-next 0/8] ethtool: rss: support creating and removing contexts via Netlink Jakub Kicinski
2025-07-17 23:43 ` [PATCH net-next 1/8] ethtool: assert that drivers with sym hash are consistent for RSS contexts Jakub Kicinski
2025-07-17 23:43 ` [PATCH net-next 2/8] ethtool: rejig the RSS notification machinery for more types Jakub Kicinski
2025-07-20 11:09 ` Gal Pressman
2025-07-17 23:43 ` [PATCH net-next 3/8] ethtool: rss: factor out allocating memory for response Jakub Kicinski
2025-07-17 23:43 ` [PATCH net-next 4/8] ethtool: rss: factor out populating response from context Jakub Kicinski
2025-07-20 11:12 ` Gal Pressman
2025-07-17 23:43 ` [PATCH net-next 5/8] ethtool: move ethtool_rxfh_ctx_alloc() to common code Jakub Kicinski
2025-07-20 11:15 ` Gal Pressman
2025-07-17 23:43 ` [PATCH net-next 6/8] ethtool: rss: support creating contexts via Netlink Jakub Kicinski
2025-07-20 11:42 ` Gal Pressman
2025-07-21 15:21 ` Jakub Kicinski [this message]
2025-07-21 18:35 ` Gal Pressman
2025-07-17 23:43 ` [PATCH net-next 7/8] ethtool: rss: support removing " Jakub Kicinski
2025-07-17 23:43 ` [PATCH net-next 8/8] selftests: drv-net: rss_api: context create and delete tests Jakub Kicinski
2025-07-22 1:40 ` [PATCH net-next 0/8] ethtool: rss: support creating and removing contexts via Netlink patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721082111.6826d138@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).