[PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[Randy Dunlap]

Add a dependency on PC104 to limit (restrict) this driver kconfig
prompt to kernel configs that have PC104 set.

Add COMPILE_TEST as a possibility for more complete build coverage.
I tested this build config on x86_64 5 times without problems.

Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andre B. Oliveira <anbadeol@gmail.com>
Cc: linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
v2: add "|| COMPILE_TEST" for build coverage (Vincent)

 drivers/net/can/sja1000/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig
+++ linux-next-20250718/drivers/net/can/sja1000/Kconfig
@@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
 
 config CAN_TSCAN1
 	tristate "TS-CAN1 PC104 boards"
-	depends on ISA
+	depends on (ISA && PC104) || COMPILE_TEST
 	help
 	  This driver is for Technologic Systems' TSCAN-1 PC104 boards.
 	  https://www.embeddedts.com/products/TS-CAN1

Re: [PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[Vincent Mailhol]

On 21/07/2025 at 09:28, Randy Dunlap wrote:
> Add a dependency on PC104 to limit (restrict) this driver kconfig
> prompt to kernel configs that have PC104 set.
> 
> Add COMPILE_TEST as a possibility for more complete build coverage.
> I tested this build config on x86_64 5 times without problems.
> 
> Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andre B. Oliveira <anbadeol@gmail.com>
> Cc: linux-can@vger.kernel.org
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>


Yours sincerely,
Vincent Mailhol

Re: [PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On 20.07.2025 17:28:23, Randy Dunlap wrote:
> Add a dependency on PC104 to limit (restrict) this driver kconfig
> prompt to kernel configs that have PC104 set.
> 
> Add COMPILE_TEST as a possibility for more complete build coverage.
> I tested this build config on x86_64 5 times without problems.

I've already Vincent's patch [1] on my tree.

[1] https://lore.kernel.org/all/20250715-can-compile-test-v2-3-f7fd566db86f@wanadoo.fr/

So this doesn't apply any more. Fixing the merge conflicts result in:

index ba16d7bc09ef..e061e35769bf 100644
--- a/drivers/net/can/sja1000/Kconfig
+++ b/drivers/net/can/sja1000/Kconfig
@@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
 
 config CAN_TSCAN1
         tristate "TS-CAN1 PC104 boards"
-        depends on ISA || (COMPILE_TEST && HAS_IOPORT)
+        depends on (ISA && PC104) || (COMPILE_TEST && HAS_IOPORT)
         help
           This driver is for Technologic Systems' TSCAN-1 PC104 boards.
           https://www.embeddedts.com/products/TS-CAN1

Should be ok?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

On 22.07.2025 12:48:41, Marc Kleine-Budde wrote:
> On 20.07.2025 17:28:23, Randy Dunlap wrote:
> > Add a dependency on PC104 to limit (restrict) this driver kconfig
> > prompt to kernel configs that have PC104 set.
> > 
> > Add COMPILE_TEST as a possibility for more complete build coverage.
> > I tested this build config on x86_64 5 times without problems.
> 
> I've already Vincent's patch [1] on my tree.
> 
> [1] https://lore.kernel.org/all/20250715-can-compile-test-v2-3-f7fd566db86f@wanadoo.fr/
> 
> So this doesn't apply any more. Fixing the merge conflicts result in:
> 
> index ba16d7bc09ef..e061e35769bf 100644
> --- a/drivers/net/can/sja1000/Kconfig
> +++ b/drivers/net/can/sja1000/Kconfig
> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>  
>  config CAN_TSCAN1
>          tristate "TS-CAN1 PC104 boards"
> -        depends on ISA || (COMPILE_TEST && HAS_IOPORT)
> +        depends on (ISA && PC104) || (COMPILE_TEST && HAS_IOPORT)
>          help
>            This driver is for Technologic Systems' TSCAN-1 PC104 boards.
>            https://www.embeddedts.com/products/TS-CAN1
> 
> Should be ok?

If no-one complains I'll add this to my can-next tree and remove the
Fixes tag. Otherwise stable will pick this up, but it won't apply
without Vincent's patch.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[Vincent Mailhol]

On 22/07/2025 at 19:52, Marc Kleine-Budde a écrit :
> On 22.07.2025 12:48:41, Marc Kleine-Budde wrote:
>> On 20.07.2025 17:28:23, Randy Dunlap wrote:
>>> Add a dependency on PC104 to limit (restrict) this driver kconfig
>>> prompt to kernel configs that have PC104 set.
>>>
>>> Add COMPILE_TEST as a possibility for more complete build coverage.
>>> I tested this build config on x86_64 5 times without problems.
>>
>> I've already Vincent's patch [1] on my tree.
>>
>> [1] https://lore.kernel.org/all/20250715-can-compile-test-v2-3-f7fd566db86f@wanadoo.fr/

Don't know how I did not realize the conflict when reviewing :D

>> So this doesn't apply any more. Fixing the merge conflicts result in:
>>
>> index ba16d7bc09ef..e061e35769bf 100644
>> --- a/drivers/net/can/sja1000/Kconfig
>> +++ b/drivers/net/can/sja1000/Kconfig
>> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>>  
>>  config CAN_TSCAN1
>>          tristate "TS-CAN1 PC104 boards"
>> -        depends on ISA || (COMPILE_TEST && HAS_IOPORT)
>> +        depends on (ISA && PC104) || (COMPILE_TEST && HAS_IOPORT)
>>          help
>>            This driver is for Technologic Systems' TSCAN-1 PC104 boards.
>>            https://www.embeddedts.com/products/TS-CAN1
>>
>> Should be ok?
> 
> If no-one complains I'll add this to my can-next tree and remove the
> Fixes tag. Otherwise stable will pick this up, but it won't apply
> without Vincent's patch.

I do not really mind if those are not backported. No issue for me to drop the
fix tag.

Yours sincerely,
Vincent Mailhol

Re: [PATCH v2] can: tscan1: CAN_TSCAN1 can depend on PC104

[Randy Dunlap]

On 7/22/25 5:12 AM, Vincent Mailhol wrote:
> On 22/07/2025 at 19:52, Marc Kleine-Budde a écrit :
>> On 22.07.2025 12:48:41, Marc Kleine-Budde wrote:
>>> On 20.07.2025 17:28:23, Randy Dunlap wrote:
>>>> Add a dependency on PC104 to limit (restrict) this driver kconfig
>>>> prompt to kernel configs that have PC104 set.
>>>>
>>>> Add COMPILE_TEST as a possibility for more complete build coverage.
>>>> I tested this build config on x86_64 5 times without problems.
>>>
>>> I've already Vincent's patch [1] on my tree.
>>>
>>> [1] https://lore.kernel.org/all/20250715-can-compile-test-v2-3-f7fd566db86f@wanadoo.fr/
> 
> Don't know how I did not realize the conflict when reviewing :D
> 
>>> So this doesn't apply any more. Fixing the merge conflicts result in:
>>>
>>> index ba16d7bc09ef..e061e35769bf 100644
>>> --- a/drivers/net/can/sja1000/Kconfig
>>> +++ b/drivers/net/can/sja1000/Kconfig
>>> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>>>  
>>>  config CAN_TSCAN1
>>>          tristate "TS-CAN1 PC104 boards"
>>> -        depends on ISA || (COMPILE_TEST && HAS_IOPORT)
>>> +        depends on (ISA && PC104) || (COMPILE_TEST && HAS_IOPORT)
>>>          help
>>>            This driver is for Technologic Systems' TSCAN-1 PC104 boards.
>>>            https://www.embeddedts.com/products/TS-CAN1
>>>
>>> Should be ok?

Looks good. Thanks.

>> If no-one complains I'll add this to my can-next tree and remove the
>> Fixes tag. Otherwise stable will pick this up, but it won't apply
>> without Vincent's patch.
> 
> I do not really mind if those are not backported. No issue for me to drop the
> fix tag.

Agreed. Not needed.

-- 
~Randy