From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, Zigit Zo <zuozhijie@bytedance.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: virtio_close() stuck on napi_disable_locked()
Date: Tue, 22 Jul 2025 14:55:24 -0700 [thread overview]
Message-ID: <20250722145524.7ae61342@kernel.org> (raw)
In-Reply-To: <c5a93ed1-9abe-4880-a3bb-8d1678018b1d@redhat.com>
On Tue, 22 Jul 2025 13:00:14 +0200 Paolo Abeni wrote:
> Hi,
>
> The NIPA CI is reporting some hung-up in the stats.py test caused by the
> virtio_net driver stuck at close time.
>
> A sample splat is available here:
>
> https://netdev-3.bots.linux.dev/vmksft-drv-hw-dbg/results/209441/4-stats-py/stderr
>
> AFAICS the issue happens only on debug builds.
>
> I'm wild guessing to something similar to the the issue addressed by
> commit 4bc12818b363bd30f0f7348dd9ab077290a637ae, possibly for tx_napi,
> but I could not spot anything obvious.
>
> Could you please have a look?
It only hits in around 1 in 5 runs. Likely some pre-existing race, but
it started popping up for us when be5dcaed694e ("virtio-net: fix
recursived rtnl_lock() during probe()") was merged. It never hit before.
If we can't find a quick fix I think we should revert be5dcaed694e for
now, so that it doesn't end up regressing 6.16 final.
next prev parent reply other threads:[~2025-07-22 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:00 virtio_close() stuck on napi_disable_locked() Paolo Abeni
2025-07-22 21:55 ` Jakub Kicinski [this message]
2025-07-23 5:14 ` Jason Wang
2025-07-23 13:51 ` Jakub Kicinski
2025-07-24 8:43 ` Paolo Abeni
2025-07-24 10:53 ` Jason Wang
2025-07-24 11:29 ` Paolo Abeni
2025-07-24 8:58 ` Zigit Zo
2025-07-24 9:18 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722145524.7ae61342@kernel.org \
--to=kuba@kernel.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=zuozhijie@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).