Re: [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet driver

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 22 Jul 2025 18:55:02 +0530 Parvathi Pudi wrote:
> +	for_each_child_of_node(eth_ports_node, eth_node) {
> +		u32 reg;
> +
> +		if (strcmp(eth_node->name, "ethernet-port"))
> +			continue;
> +		ret = of_property_read_u32(eth_node, "reg", &reg);
> +		if (ret < 0) {
> +			dev_err(dev, "%pOF error reading port_id %d\n",
> +				eth_node, ret);
> +			return ret;

missing put for eth_node

> +		}
> +
> +		of_node_get(eth_node);
> +
> +		if (reg == 0 && !eth0_node) {
> +			eth0_node = eth_node;
> +			if (!of_device_is_available(eth0_node)) {
> +				of_node_put(eth0_node);
> +				eth0_node = NULL;
> +			}
> +		} else if (reg == 1 && !eth1_node) {
> +			eth1_node = eth_node;
> +			if (!of_device_is_available(eth1_node)) {
> +				of_node_put(eth1_node);
> +				eth1_node = NULL;
> +			}
> +		} else {
> +			if (reg == 0 || reg == 1)
> +				dev_err(dev, "duplicate port reg value: %d\n",
> +					reg);
> +			else
> +				dev_err(dev, "invalid port reg value: %d\n",
> +					reg);
> +
> +			of_node_put(eth_node);
> +		}
> +	}
-- 
pw-bot: cr