Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuba@kernel.org,
	n.zhandarovich@fintech.ru, edumazet@google.com,
	pabeni@redhat.com, wojciech.drewek@intel.com,
	Arvid.Brodin@xdin.com, horms@kernel.org, lukma@denx.de,
	m-karicheri2@ti.com
Subject: Re: [PATCH net-next] net: hsr: create an API to get hsr port type
Date: Wed, 23 Jul 2025 13:06:08 +0300	[thread overview]
Message-ID: <20250723100608.apixcv3ix5rn7ydz@skbuf> (raw)
In-Reply-To: <20250723100605.23860-1-xiaoliang.yang_1@nxp.com>

Hi Xiaoliang,

On Wed, Jul 23, 2025 at 06:06:05PM +0800, Xiaoliang Yang wrote:
> If a switch device has HSR hardware ability and HSR configuration
> offload to hardware. The device driver needs to get the HSR port type
> when joining the port to HSR. Different port types require different
> settings for the hardware, like HSR_PT_SLAVE_A, HSR_PT_SLAVE_B, and
> HSR_PT_INTERLINK. Create the API hsr_get_port_type() and export it.
> 
> When the hsr_get_port_type() is called in the device driver, if the port
> can be found in the HSR port list, the HSR port type can be obtained.
> Therefore, before calling the device driver, we need to first add the
> hsr_port to the HSR port list.
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---

An API with no callers will never be accepted. You need to post the user
together with this change, for the maintainers to have the full picture
and see whether it is the best way to solve the problem.

  reply	other threads:[~2025-07-23 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 10:06 [PATCH net-next] net: hsr: create an API to get hsr port type Xiaoliang Yang
2025-07-23 10:06 ` Vladimir Oltean [this message]
2025-07-23 10:29   ` Xiaoliang Yang
2025-07-23 10:37     ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250723100608.apixcv3ix5rn7ydz@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=Arvid.Brodin@xdin.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukma@denx.de \
    --cc=m-karicheri2@ti.com \
    --cc=n.zhandarovich@fintech.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wojciech.drewek@intel.com \
    --cc=xiaoliang.yang_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox