From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: maher azz <maherazz04@gmail.com>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, Ferenc Fejes <fejes@inf.elte.hu>
Subject: Re: [PATCH net] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing
Date: Wed, 23 Jul 2025 17:31:41 +0300 [thread overview]
Message-ID: <20250723143141.dnhct6w22uzi7ufk@skbuf> (raw)
In-Reply-To: <CAFQ-Uc_qYu--YG4LNVOB=UQeUGyuQ9fSPT=e52HwHu-j3kjQtQ@mail.gmail.com>
Hi Maher,
On Wed, Jul 23, 2025 at 02:01:52PM +0100, maher azz wrote:
> Hello,
>
> Thank you for taking the time to look into it. Should I remove the
> “reported by” tag? resend another patch or is it fine like that?
>
> Best regards,
> Maher
For an initial patch submission, the quality is reasonable. But it needs
improvement before it can be merged, and I recommend submitting a v2, no
earlier than 24 hours after the initial submission.
Some comments:
1. The "Author:" (in git; in the email it is the "From:" field) and last
"Signed-off-by:" tag need to coincide. In your case, they point to
the same person (you), but the formatting is different, so they don't
coincide. Please fix your "git config --global user.name" in the way
that Simon indicated.
2. Please don't top-post. Trim the quoted email to just the relevant
portions you're responding to, and respond below the quoted email.
3. Please configure your email client to respond only using plain-text
emails, no HTML.
next prev parent reply other threads:[~2025-07-23 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 15:51 [PATCH net] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing Maher Azzouzi
2025-07-23 12:55 ` Simon Horman
[not found] ` <CAFQ-Uc_qYu--YG4LNVOB=UQeUGyuQ9fSPT=e52HwHu-j3kjQtQ@mail.gmail.com>
2025-07-23 14:31 ` Vladimir Oltean [this message]
2025-07-23 14:41 ` Vladimir Oltean
2025-07-25 18:03 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723143141.dnhct6w22uzi7ufk@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fejes@inf.elte.hu \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maherazz04@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox