From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: yicongsrfy@163.com, andrew+netdev@lunn.ch, davem@davemloft.net,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
oneukum@suse.com, yicong@kylinos.cn
Subject: Re: [PATCH] usbnet: Set duplex status to unknown in the absence of MII
Date: Wed, 23 Jul 2025 15:21:51 -0700 [thread overview]
Message-ID: <20250723152151.70a8034b@kernel.org> (raw)
In-Reply-To: <d8852211-e3ba-4c9e-a9ab-798e1b8d802e@lunn.ch>
On Wed, 23 Jul 2025 15:05:27 +0200 Andrew Lunn wrote:
> > > Thanks for checking this.
> > >
> > > Just one more question. This is kind of flipping the question on its
> > > head. Does the standard say devices are actually allowed to support
> > > 1/2 duplex? Does it say they are not allowed to support 1/2 duplex?
> > >
> > > If duplex is not reported, maybe it is because 1/2 duplex is simply
> > > not allowed, so there is no need to report it.
> > >
> >
> > No, the standard does not mention anything about duplex at all.
>
> O.K. So please set duplex to unknown.
.. and update the commit message and the code comment to reflect
the outcome of the discussion better.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-23 22:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 7:10 [PATCH] usbnet: Set duplex status to unknown in the absence of MII yicongsrfy
2025-07-21 13:51 ` Andrew Lunn
2025-07-22 2:09 ` yicongsrfy
2025-07-22 13:06 ` Andrew Lunn
2025-07-23 1:29 ` yicongsrfy
2025-07-23 7:17 ` Oliver Neukum
2025-07-23 8:44 ` yicongsrfy
2025-07-23 10:03 ` Oliver Neukum
2025-07-23 13:04 ` Andrew Lunn
2025-07-23 13:05 ` Andrew Lunn
2025-07-23 22:21 ` Jakub Kicinski [this message]
2025-07-24 1:31 ` [PATCH v2] " yicongsrfy
2025-07-24 9:03 ` Oliver Neukum
2025-07-25 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723152151.70a8034b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=yicong@kylinos.cn \
--cc=yicongsrfy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).