From: Pengtao He <hept.hept.hept@gmail.com>
To: willemdebruijn.kernel@gmail.com
Cc: aleksander.lobakin@intel.com, almasrymina@google.com,
davem@davemloft.net, ebiggers@google.com, edumazet@google.com,
hept.hept.hept@gmail.com, horms@kernel.org,
kerneljasonxing@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, mhal@rbox.co,
netdev@vger.kernel.org, pabeni@redhat.com, willemb@google.com
Subject: Re: [PATCH] net/core: fix wrong return value in __splice_segment
Date: Thu, 24 Jul 2025 18:06:10 +0800 [thread overview]
Message-ID: <20250724100610.6702-1-hept.hept.hept@gmail.com> (raw)
In-Reply-To: <6880e365b84d2_334c6729452@willemb.c.googlers.com.notmuch>
> Pengtao He wrote:
> > Return true immediately when the last segment is processed,
> > without waiting for the next segment.
>
> This can use a bit more explanation. Which unnecessary wait is
> avoided.
>
> The boolean return from __skb_splice_bits has a bit odd semantics. But
> is ignored by its only caller anyway.
>
> The relevant __splice_segment that can cause an early return is in the
> frags loop. But I see no waiting operation in here.
Sorry, I didn't express it clearly.
There is no wait operation, just avoid to walking once more
in the frags loop before return true.
>
> Aside from that, the commit also should target [PATCH net-next],
> assuuming that this is an optimization, not a fix.
Ok, the prefix [PATCH net-next] will be used.
prev parent reply other threads:[~2025-07-24 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 6:31 [PATCH] net/core: fix wrong return value in __splice_segment Pengtao He
2025-07-23 13:28 ` Willem de Bruijn
2025-07-24 10:06 ` Pengtao He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724100610.6702-1-hept.hept.hept@gmail.com \
--to=hept.hept.hept@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).