Re: [PATCH net v2] vrf: Drop existing dst reference in vrf_ip6_input_dst

Stanislav Fomichev
2025-07-24T18:06:50Z

On 07/24, Ido Schimmel wrote:
> On Wed, Jul 23, 2025 at 03:46:25PM -0700, Stanislav Fomichev wrote:
> > Commit 8fba0fc7b3de ("selftests: tc: Add generic erspan_opts matching support
> > for tc-flower") started triggering the following kmemleak warning:
>
> Did you mean
>
> ff3fbcdd4724 ("selftests: tc: Add generic erspan_opts matching support for tc-flower")
>
> ?

Both seem to be reachable in my local tree:

$ git log --oneline 8fba0fc7b3dec1abc4dd57449d578d8c2682d60e | head
8fba0fc7b3de selftests: tc: Add generic erspan_opts matching support for tc-flower
a6906c86ff9c net: phy: qcom: qca807x: Enable WoL support using shared library
dea37f39a2ce ptp: prevent possible ABBA deadlock in ptp_clock_freerun()
545a0b84c678 netfilter: xt_nfacct: don't assume acct name is null-terminated
f472ea3cce90 netvsc: transfer lower device max tso size
a9a96c581e88 net: usb: smsc95xx: add support for ethtool pause parameters
5be49dfee611 selftests: drv-net: rss_api: context create and delete tests
4ee6aab279d6 ethtool: rss: support removing contexts via Netlink
8bd3be3a6690 ethtool: rss: support creating contexts via Netlink
f6a1fa5e4327 ethtool: move ethtool_rxfh_ctx_alloc() to common code

$ git log --oneline ff3fbcdd472453190d4f37fe1d1e69e50cce7612 | head
ff3fbcdd4724 selftests: tc: Add generic erspan_opts matching support for tc-flower
dd500e4aecf2 net: usb: Remove duplicate assignments for net->pcpu_stat_type
4701ee5044fb be2net: Use correct byte order and format string for TCP seq and ack_seq
190ccb817637 net: bcmasp: Add support for re-starting auto-negotiation
e07ba344a465 Merge branch 'net-maintain-netif-vs-dev-prefix-semantics'
88d3cec28274 net: s/dev_close_many/netif_close_many/
5d4d84618e1a net: s/dev_set_threaded/netif_set_threaded/
93893a57efd4 net: s/dev_get_flags/netif_get_flags/
303a8487a657 net: s/__dev_set_mtu/__netif_set_mtu/
0413a34ef678 net: s/dev_pre_changeaddr_notify/netif_pre_changeaddr_notify/

But yours is indeed the one that is in net-next. Not sure how that
happened.

> [...]
>
> > vrf_ip6_input_dst unconditionally sets skb dst entry, add a call to
> > skb_dst_drop to drop any existing entry.
> >
> > Cc: David Ahern <dsahern@kernel.org>
> > Fixes: 9ff74384600a ("net: vrf: Handle ipv6 multicast and link-local addresses")
> > Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks!