From: Simon Horman <horms@kernel.org>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: shannon.nelson@amd.com, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, corbet@lwn.net, jgg@ziepe.ca, leon@kernel.org,
andrew+netdev@lunn.ch, allen.hubbe@amd.com,
nikhil.agarwal@amd.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 03/14] net: ionic: Export the APIs from net driver to support device commands
Date: Fri, 25 Jul 2025 17:41:06 +0100 [thread overview]
Message-ID: <20250725164106.GI1367887@horms.kernel.org> (raw)
In-Reply-To: <20250723173149.2568776-4-abhijit.gangurde@amd.com>
On Wed, Jul 23, 2025 at 11:01:38PM +0530, Abhijit Gangurde wrote:
> RDMA driver needs to establish admin queues to support admin operations.
> Export the APIs to send device commands for the RDMA driver.
>
> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
Hi Abhijit,
Perhaps I misunderstand things, or otherwise am on the wrong track here.
But this seems to open the possibility of users of ionic_adminq_post_wait(),
outside the Ethernet driver, executing a wide range or admin commands.
It seems to me that it would be nice to narrow that surface.
...
next prev parent reply other threads:[~2025-07-25 16:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 17:31 [PATCH v4 00/14] Introduce AMD Pensando RDMA driver Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 01/14] net: ionic: Create an auxiliary device for rdma driver Abhijit Gangurde
2025-07-23 18:11 ` Shannon Nelson
2025-07-28 10:17 ` Abhijit Gangurde
2025-08-01 21:15 ` Christophe JAILLET
2025-08-06 8:14 ` Abhijit Gangurde
2025-08-09 10:58 ` Christophe JAILLET
2025-07-23 17:31 ` [PATCH v4 02/14] net: ionic: Update LIF identity with additional RDMA capabilities Abhijit Gangurde
2025-07-25 16:29 ` Simon Horman
2025-07-23 17:31 ` [PATCH v4 03/14] net: ionic: Export the APIs from net driver to support device commands Abhijit Gangurde
2025-07-25 16:41 ` Simon Horman [this message]
2025-08-01 17:00 ` Jason Gunthorpe
2025-08-01 20:21 ` Jakub Kicinski
2025-08-06 7:54 ` Abhijit Gangurde
2025-08-06 17:58 ` Leon Romanovsky
2025-07-23 17:31 ` [PATCH v4 04/14] net: ionic: Provide RDMA reset support for the RDMA driver Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 05/14] net: ionic: Provide interrupt allocation " Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 06/14] net: ionic: Provide doorbell and CMB region information Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 07/14] RDMA: Add IONIC to rdma_driver_id definition Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 08/14] RDMA/ionic: Register auxiliary module for ionic ethernet adapter Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 09/14] RDMA/ionic: Create device queues to support admin operations Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 10/14] RDMA/ionic: Register device ops for control path Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 11/14] RDMA/ionic: Register device ops for datapath Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 12/14] RDMA/ionic: Register device ops for miscellaneous functionality Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 13/14] RDMA/ionic: Implement device stats ops Abhijit Gangurde
2025-07-23 17:31 ` [PATCH v4 14/14] RDMA/ionic: Add Makefile/Kconfig to kernel build environment Abhijit Gangurde
2025-07-23 18:10 ` Randy Dunlap
2025-07-30 5:12 ` Abhijit Gangurde
2025-07-23 18:13 ` Shannon Nelson
2025-07-28 10:25 ` Abhijit Gangurde
2025-07-24 15:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725164106.GI1367887@horms.kernel.org \
--to=horms@kernel.org \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).