From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>
Subject: Re: [PATCH net-next v3 2/3] net: wangxun: limit tx_max_coalesced_frames_irq
Date: Fri, 25 Jul 2025 17:31:58 -0700 [thread overview]
Message-ID: <20250725173158.7d372bb4@kernel.org> (raw)
In-Reply-To: <20250724080548.23912-3-jiawenwu@trustnetic.com>
On Thu, 24 Jul 2025 16:05:47 +0800 Jiawen Wu wrote:
> Add limitation on tx_max_coalesced_frames_irq as 0 ~ 65535, because
> 'wx->tx_work_limit' is declared as a member of type u16.
okay if that's the case then..
> - if (ec->tx_max_coalesced_frames_irq)
> - wx->tx_work_limit = ec->tx_max_coalesced_frames_irq;
> + if (ec->tx_max_coalesced_frames_irq > WX_MAX_TX_WORK ||
if (ec->tx_max_coalesced_frames_irq > U16_MAX ||
? why create a new define if the boundary is basically dictated
by type width?
next prev parent reply other threads:[~2025-07-26 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 8:05 [PATCH net-next v3 0/3] net: wangxun: complete ethtool coalesce options Jiawen Wu
2025-07-24 8:05 ` [PATCH net-next v3 1/3] net: wangxun: change the default ITR setting Jiawen Wu
2025-07-26 0:30 ` Jakub Kicinski
2025-07-24 8:05 ` [PATCH net-next v3 2/3] net: wangxun: limit tx_max_coalesced_frames_irq Jiawen Wu
2025-07-26 0:31 ` Jakub Kicinski [this message]
2025-07-24 8:05 ` [PATCH net-next v3 3/3] net: wangxun: support to use adaptive RX coalescing Jiawen Wu
2025-07-26 0:34 ` Jakub Kicinski
2025-07-28 2:15 ` Jiawen Wu
2025-07-28 15:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725173158.7d372bb4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).