From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289C0126F0A for ; Mon, 28 Jul 2025 03:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753671698; cv=none; b=jAAVYlF+ABl99eyhqnbQJStVPReE+YwYsoFLt22pcRIfC4pXU5sAiUWQWsodPZu10ukdeRabgJ4Zazeyx6xy57JM6MwgM/MSugBgJHWRyn8fn11jtkj9HiBewMC/OH+yNe6q1n4OVxAlRZUwtFZzAZ8yiGfKfiFTozDfCMDDv6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753671698; c=relaxed/simple; bh=0vKfwUHfNQR2JxpeH1mjLInwJuziDSzoCPLeGXD166w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=STe6gIRVn9y8LYEN1D77Ke1bepM9MYtmHKY4rOsIzxWY74xdCkwzuFgcV9Q1pNFvULmiSYWg4IktroZWtjoe+D9Qv3Rc1bgJ1CDcCIjPefn578av3pYoI3XQemSzH/9Omo0xEvtif4stGkX39Gc84JdYOKU2xYeYufv1CthP7ic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=i1TEqPCP; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="i1TEqPCP" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4561ed868b5so25334195e9.0 for ; Sun, 27 Jul 2025 20:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1753671694; x=1754276494; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oEoci9qMGq3mZsbtJsvexp6JhXmJXNusPRjzxxOh55E=; b=i1TEqPCP7dFx6y1M+V4DDDgQIGYukkyZyCUilAIy7nI8XAniubEi918sU3QqNb/X+J URwHFw9YKVwbWAeCEoibkfjc1a75NNOn4yiWUfUYhLpoJBMQg6JW28lMCQ0VB99HFJ/O LDwjNiK9tuofO4qaCAEuxN/BOWLaEhcUpwcEJrJJ9Uw26C5dkjaN7lCreUcg7aIIsw02 0v5RjDf7uAUi8MAlv8vLMmxMIMysC8sEMWy1tQwFRL6a6WxLnusauBHumPjsQ4ad95/3 XmIo/0Ls8nVrt9fh656YX1+ChIxh14fQQn1Ps05X4J7sf/GGyi2zyS4CW5oXQaWcOv9H KGJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753671694; x=1754276494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oEoci9qMGq3mZsbtJsvexp6JhXmJXNusPRjzxxOh55E=; b=czr/UxnmfNx4zV66N7GOoqVwUuBh7NietBjdD9DqRnrXwCkOsR8ayPd3zYPVmL28At Hk/v63PhPMjp2OGB9TBIJv3NYg+yyCj/XXtBwe6PE1mn+JabL10/pgZP7y4h6HHPv7HE 2MaIMjC6J6XxU5uS3a/1i758ZrjDC7jH+YEpCffVI8Mbog+4E/XsL+pv8uvF/qJ6YmlN kOP/MgXdj8ZlixyRGZhLipy50sSwNXtqurnoV8uKo0XZemJ7rCRlpi0aosEoDHy8ezFQ NEVR930scal438YBXApKR6E/SYuyVE+txhAK5IO3my9y1QthRFSZ10f845cKbtNIJqiU nqAw== X-Forwarded-Encrypted: i=1; AJvYcCXl03zWo1AWEy+I5xpmU3HtafG3TKI2fPckM63p0jDOm+VEI8wIH5KKOpZMzHdYAlhsddmDqSg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxvw0fLnZ/2M43nLJ7eh6mp9L0nGMhI3sxrFaBZBwnk6N8lPpL1 gEFKm1P5o6ry6vy6efmuDrc3zKquUcRFwdJz67RsY4XYB3wrEMfCB+2FKA0fvS5N4P0= X-Gm-Gg: ASbGncuoDAJlSy786jqD8EiBWHWeJLEA9klZ7RBMl1xuEVANYjDLwEWBfkRv7e3kEOO JduD6ISPeaWVb/KSj4za72OhQ3ZNnlb8/bLMFpygMurobGXQYAA7gOn7s/JI3gefWabiLAEbO8B kZej3Mc+EbFbA+KjLitk4vbUetf9h0ATu81N/xSUoK17cToV3riK2p1307ZDnGptRdgO5Vfo6P6 RSqzF+or0VWLjMokMWGXy7c2raX9pgpoH7LHoi9QX0JXB1DpWNzQ7Q90nJKNehpBeaxomisgoKt Gux2kOKui+0LS8TUJlAzvL+TmPZZ2rnH3evKObeqpyqIun4wUitXzNbQYccwVUa3nJ9Il3L2rDt ETW3QhmImc0XdItMgi01c9UF9+tTW2SqA6A64tpuN1FHt28x8d/fUHv8PzDVHqxlbKeEWRU61BW k= X-Google-Smtp-Source: AGHT+IGQxNb0uTRmgaXFIWNAxJsx2ABBH3vJc/u5BlArY34ZoKzsrRmq3jNV4kVoBvHvbjNr05ibwQ== X-Received: by 2002:a05:600c:6812:b0:456:207e:fd83 with SMTP id 5b1f17b1804b1-458762fcfe9mr81396495e9.4.1753671694214; Sun, 27 Jul 2025 20:01:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4587054f2e6sm137373995e9.12.2025.07.27.20.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Jul 2025 20:01:33 -0700 (PDT) Date: Sun, 27 Jul 2025 20:01:26 -0700 From: Stephen Hemminger To: Jakub Kicinski Cc: Haiyang Zhang , Jason Wang , Cindy Lu , KY Srinivasan , Wei Liu , Dexuan Cui , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Michael Kelley , Shradha Gupta , Kees Cook , Stanislav Fomichev , Kuniyuki Iwashima , Alexander Lobakin , Guillaume Nault , Joe Damato , Ahmed Zaki , "open list:Hyper-V/Azure CORE AND DRIVERS" , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH RESEND] netvsc: transfer lower device max tso size Message-ID: <20250727200126.2682aa39@hermes.local> In-Reply-To: <20250723151622.0606cc99@kernel.org> References: <20250718061812.238412-1-lulu@redhat.com> <20250721162834.484d352a@kernel.org> <20250721181807.752af6a4@kernel.org> <20250723080532.53ecc4f1@kernel.org> <20250723151622.0606cc99@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 23 Jul 2025 15:16:22 -0700 Jakub Kicinski wrote: > On Wed, 23 Jul 2025 20:18:03 +0000 Haiyang Zhang wrote: > > > > Btw, if I understand this correctly. This is for future development so > > > > it's not a blocker for this patch? > > > > > > Not a blocker, I'm just giving an example of the netvsc auto-weirdness > > > being a source of tech debt and bugs. Commit d7501e076d859d is another > > > recent one off the top of my head. IIUC systemd-networkd is broadly > > > deployed now. It'd be great if there was some migration plan for moving > > > this sort of VM auto-bonding to user space (with the use of the common > > > bonding driver, not each hypervisor rolling its own). > > > > Actually, we had used the common bonding driver 9 years ago. But it's > > replaced by this kernel/netvsc based "transparent" bonding mode. See > > the patches listed below. > > > > The user mode bonding scripts were unstable, and difficult to deliver > > & update for various distros. So Stephen developed the new "transparent" > > bonding mode, which greatly improves the situation. > > I specifically highlighted systemd-networkd as the change in the user > space landscape. Haiyang tried valiantly but getting every distro to do the right thing with VF's bonding and hot plug was impossible to support.