From: Jakub Kicinski <kuba@kernel.org>
To: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>
Cc: Simon Horman <horms@kernel.org>,
"Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [RFC net-next v1 1/1] e1000e: Introduce private flag and module param to disable K1
Date: Wed, 30 Jul 2025 13:42:13 -0700 [thread overview]
Message-ID: <20250730134213.36f1f625@kernel.org> (raw)
In-Reply-To: <20250730152848.GJ1877762@horms.kernel.org>
On Wed, 30 Jul 2025 16:28:48 +0100 Simon Horman wrote:
> My opinion is that devlink is the correct way to solve this problem.
> However, I do understand from the responses above (3) that this is somewhat
> non-trivial to implement and thus comes with some risks. And I do accept
> your argument that for old drivers, which already use module parameters,
> some pragmatism seems appropriate.
>
> IOW, I drop my objection to using a module parameter in this case.
>
> What I would suggest is that some consideration is given to adding devlink
> support to this driver. And thus modernising it in that respect. Doing so
> may provide better options for users in future.
FWIW I will still object. The ethtool priv flag is fine, personally
I don't have a strong preference on devlink vs ethtool priv flags.
But if you a module param you'd need a very strong justification..
next prev parent reply other threads:[~2025-07-30 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 9:24 [RFC net-next v1 1/1] e1000e: Introduce private flag and module param to disable K1 Vitaly Lifshits
2025-07-14 16:55 ` Simon Horman
2025-07-14 21:30 ` Keller, Jacob E
2025-07-16 10:25 ` Ruinskiy, Dima
2025-07-30 14:11 ` Lifshits, Vitaly
2025-07-30 15:28 ` Simon Horman
2025-07-30 20:42 ` Jakub Kicinski [this message]
2025-07-30 22:10 ` Jacob Keller
2025-07-31 0:06 ` Jakub Kicinski
2025-07-31 7:00 ` Ruinskiy, Dima
2025-07-31 14:19 ` Jakub Kicinski
2025-07-31 15:51 ` Jacob Keller
2025-08-03 12:38 ` Lifshits, Vitaly
2025-08-28 7:15 ` En-Wei WU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730134213.36f1f625@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).