[PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments

[PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments

[Jakub Kicinski]

Module (SFP) eeprom GET has a lot of input params, they are all
mistakenly listed as output in the spec. Looks like kernel doesn't
output them at all. Correct what are the inputs and what the outputs.

Reported-by: Duo Yi <duo@meta.com>
Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: andrew@lunn.ch
CC: donald.hunter@gmail.com
CC: kory.maincent@bootlin.com
CC: sdf@fomichev.me
---
 Documentation/netlink/specs/ethtool.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 1063d5d32fea..1bc1bd7d33c2 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -2342,9 +2342,6 @@ c-version-name: ethtool-genl-version
 
       do: &module-eeprom-get-op
         request:
-          attributes:
-            - header
-        reply:
           attributes:
             - header
             - offset
@@ -2352,6 +2349,9 @@ c-version-name: ethtool-genl-version
             - page
             - bank
             - i2c-address
+        reply:
+          attributes:
+            - header
             - data
       dump: *module-eeprom-get-op
     -
-- 
2.50.1

Re: [PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments

[Stanislav Fomichev]

On 07/30, Jakub Kicinski wrote:
> Module (SFP) eeprom GET has a lot of input params, they are all
> mistakenly listed as output in the spec. Looks like kernel doesn't
> output them at all. Correct what are the inputs and what the outputs.
> 
> Reported-by: Duo Yi <duo@meta.com>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

(seems to match what eeprom_parse_request and eeprom_fill_reply are
doing)

Re: [PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 30 Jul 2025 10:21:37 -0700 you wrote:
> Module (SFP) eeprom GET has a lot of input params, they are all
> mistakenly listed as output in the spec. Looks like kernel doesn't
> output them at all. Correct what are the inputs and what the outputs.
> 
> Reported-by: Duo Yi <duo@meta.com>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] netlink: specs: ethtool: fix module EEPROM input/output arguments
    https://git.kernel.org/netdev/net/c/010510128873

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html