netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v7 net-next 0/2] net: Prevent RPS table overwrite of active flows
@ 2025-07-29 10:41 Krishna Kumar
  2025-07-29 10:41 ` [PATCH v7 net-next 1/2] " Krishna Kumar
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Krishna Kumar @ 2025-07-29 10:41 UTC (permalink / raw)
  To: netdev
  Cc: davem, edumazet, tom, kuba, pabeni, horms, sdf, kuniyu,
	ahmed.zaki, aleksander.lobakin, atenart, krishna.ku, krikku

This series splits the original RPS patch [1] into two patches for
net-next. It also addresses a kernel test robot warning by defining
rps_flow_is_active() only when aRFS is enabled. I tested v3 with
four builds and reboots: two for [PATCH 1/2] with aRFS enabled &
disabled, and two for [PATCH 2/2]. There are no code changes in v4
and v5, only documentation. Patch v6 has one line change to keep
'hash' field under #ifdef, and was test built with aRFS=on and
aRFS=off. The same two builds were done for v7, along with 15m load
testing with aRFS=on to ensure the new changes are correct.

The first patch prevents RPS table overwrite for active flows thereby
improving aRFS stability.

The second patch caches hash & flow_id in get_rps_cpu() to avoid
recalculating it in set_rps_cpu() (this patch depends on the first).

[1] https://lore.kernel.org/netdev/20250708081516.53048-1-krikku@gmail.com/
[2] https://lore.kernel.org/netdev/20250717064554.3e4d9993@kernel.org/

Signed-off-by: Krishna Kumar <krikku@gmail.com>
---
v7: Improve readability of rps_flow_is_active() and remove some
    unnecessary comments.
v6: Keep 'hash' in 'rps_dev_flow' under aRFS config.
v5: Same v4 patch sent with a change in documentation style for "return".
v4: Same v3 patch sent as a new thread instead of a continuation.
v3: Wrapped rps_flow_is_active() in #ifdef CONFIG_RFS_ACCEL to fix
    unused function warning reported by kernel test robot.
v2: Split original patch into two: RPS table overwrite prevention and hash/
    flow_id caching.


Krishna Kumar (2):
  net: Prevent RPS table overwrite of active flows
  net: Cache hash and flow_id to avoid recalculation

 include/net/rps.h    |  7 +++--
 net/core/dev.c       | 71 +++++++++++++++++++++++++++++++++++++-------
 net/core/net-sysfs.c |  4 ++-
 3 files changed, 68 insertions(+), 14 deletions(-)

-- 
2.39.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-08-02  3:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 10:41 [PATCH v7 net-next 0/2] net: Prevent RPS table overwrite of active flows Krishna Kumar
2025-07-29 10:41 ` [PATCH v7 net-next 1/2] " Krishna Kumar
2025-07-29 10:41 ` [PATCH v7 net-next 2/2] net: Cache hash and flow_id to avoid recalculation Krishna Kumar
2025-08-01 21:35 ` [PATCH v7 net-next 0/2] net: Prevent RPS table overwrite of active flows Jakub Kicinski
2025-08-02  3:19   ` Krishna Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).