netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] benet: fix BUG when creating VFs
Date: Mon, 4 Aug 2025 17:20:55 -0700	[thread overview]
Message-ID: <20250804172055.0b865696@kernel.org> (raw)
In-Reply-To: <20250801101338.72502-1-mschmidt@redhat.com>

On Fri,  1 Aug 2025 12:13:37 +0200 Michal Schmidt wrote:
> benet crashes as soon as SRIOV VFs are created:

>  err:
> -	dma_free_coherent(&adapter->pdev->dev, cmd.size, cmd.va, cmd.dma);
>  	spin_unlock_bh(&adapter->mcc_lock);
> +	dma_free_coherent(&adapter->pdev->dev, cmd.size, cmd.va, cmd.dma);
>  	return status;
>  }
>  

Quick grep reveals an identical problem in be_cmd_get_phy_info() ?
Or is this bug size-sensitive ? I don't see the vunmap call..

  parent reply	other threads:[~2025-08-05  0:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 10:13 [PATCH net] benet: fix BUG when creating VFs Michal Schmidt
2025-08-01 10:24 ` Nikolay Aleksandrov
2025-08-05  0:20 ` Jakub Kicinski [this message]
2025-08-05 12:52   ` Michal Schmidt
2025-08-05  0:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250804172055.0b865696@kernel.org \
    --to=kuba@kernel.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).