From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECD4A2BD588;
	Tue,  5 Aug 2025 23:09:39 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1754435380; cv=none; b=XoTnq5yrDTrIwbA85NFtPeZMtuiefdQQSRWrPBUIQgrR/Kz/8CLqJTT6KaIDrUbO1lhSteB7f+hCfrnNpuFtiZ1oHVrCDf80vmO/jr9yPNkRz/T3eQXtZcHaAQvb8tLHAzFRbD67dLrsQ0wTNQtXP8dRV3xCREcz0sKLK9F3Bik=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1754435380; c=relaxed/simple;
	bh=b+4gC3jrvqG+83u5Vh0Kk2KArZaArOezV8zzx5Mi8Pw=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=DeFe/hq217zrz5MKS1hXgFwNzFZChpWGB+BEstBmKzCqKs2xsZ8qh0lK5ZdmUpEKoFl8leX7KLNb5hpdd7G9s/JDuypETvG2O9/8FefRq3X2+8SJU6xLaXzLcfbbangW4KrXgPqsgVlW4+nqAnBNGROM2jZn4rLjg6GFKonrH+w=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ssgplbCF; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ssgplbCF"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2717BC4CEF0;
	Tue,  5 Aug 2025 23:09:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1754435379;
	bh=b+4gC3jrvqG+83u5Vh0Kk2KArZaArOezV8zzx5Mi8Pw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=ssgplbCFi6TgjsQZXxa8e5ZrcwMPNsDUh0sVbNcJY/6wIfXMV9HIc9Oyh+CQRgqWW
	 CFn/E7H+vaNflQdu0HuRxDFgItGFd4cEbxzzA858j4GL9PCVqCNjOoHJjQ21V9neYY
	 RrhtlUKVQUstu5nrtT+Xv5pol32pPlj6X65ZBc59Bq6tfIblY9xqIBXdOVy3UdjGdM
	 mVJmoRg4yabba0OeBZ+2DkcAGxSlEee+htvi3KVE1VoIdOPxSuCzp+FeuDB7huV1hZ
	 wRz4RC3J9fKK8yBmc+MO1GnzZnrcccH4WuxicCsRoCdetYCHSiHuRophBGf//hwztb
	 OCK8qK3/8CR1Q==
Date: Tue, 5 Aug 2025 16:09:38 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Tariq Toukan <tariqt@nvidia.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
 Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
 netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eth: mlx4: Fix IS_ERR() vs NULL check bug in
 mlx4_en_create_rx_ring
Message-ID: <20250805160720.0187e36d@kernel.org>
In-Reply-To: <20250805025057.3659898-1-linmq006@gmail.com>
References: <20250805025057.3659898-1-linmq006@gmail.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue,  5 Aug 2025 06:50:57 +0400 Miaoqian Lin wrote:
>  	ring->pp = page_pool_create(&pp);
> -	if (!ring->pp)
> +	if (IS_ERR(ring->pp))
>  		goto err_ring;

Thanks for fixing! Looks we previously depended on err being initialized
to -ENOMEM, but since we have an errno now, I think it'd be better to
use it:

	if (IS_ERR(ring->pp)) {
		err = PTR_ERR(ring->pp);
		goto err_ring;
	}