From: Simon Horman <horms@kernel.org>
To: Jacek Kowalski <jacek@jacekk.info>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next v3 3/5] igb: drop unnecessary constant casts to u16
Date: Fri, 8 Aug 2025 14:44:30 +0100 [thread overview]
Message-ID: <20250808134430.GC4654@horms.kernel.org> (raw)
In-Reply-To: <e16d5318-3e5c-4a4a-a629-ba221a5f04c5@jacekk.info>
On Wed, Jul 23, 2025 at 10:55:03AM +0200, Jacek Kowalski wrote:
> Remove unnecessary casts of constant values to u16.
> C's integer promotion rules make them ints no matter what.
>
> Additionally replace IGB_MNG_VLAN_NONE with resulting value
> rather than casting -1 to u16.
>
> Signed-off-by: Jacek Kowalski <jacek@jacekk.info>
> Suggested-by: Simon Horman <horms@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-08-08 13:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:53 [PATCH iwl-next v3 0/5] drop unnecessary constant casts to u16 Jacek Kowalski
2025-07-23 8:54 ` [PATCH iwl-next v3 1/5] e1000: " Jacek Kowalski
2025-07-23 10:06 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-08-08 13:44 ` Simon Horman
2025-07-23 8:54 ` [PATCH iwl-next v3 2/5] e1000e: " Jacek Kowalski
2025-07-23 10:07 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-08-08 13:44 ` Simon Horman
2025-07-23 8:55 ` [PATCH iwl-next v3 3/5] igb: " Jacek Kowalski
2025-07-23 10:08 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-08-08 11:34 ` Rinitha, SX
2025-08-08 13:44 ` Simon Horman [this message]
2025-07-23 8:55 ` [PATCH iwl-next v3 4/5] igc: " Jacek Kowalski
2025-07-23 10:09 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-08-08 13:44 ` Simon Horman
2025-07-23 8:55 ` [PATCH iwl-next v3 5/5] ixgbe: drop unnecessary casts to u16 / int Jacek Kowalski
2025-07-23 10:10 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-08-08 9:46 ` Rinitha, SX
2025-08-08 13:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808134430.GC4654@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacek@jacekk.info \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).