From: Jakub Kicinski <kuba@kernel.org>
To: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Cc: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
neescoba@cisco.com, johndale@cisco.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akhileshpatilvnit@gmail.com,
skhan@linuxfoundation.org
Subject: Re: [PATCH] enic: use string choice helpers to simplify dev_info arguments
Date: Mon, 11 Aug 2025 08:56:48 -0700 [thread overview]
Message-ID: <20250811085648.449a605a@kernel.org> (raw)
In-Reply-To: <aJjzFb6c6OCGib2F@bhairav-test.ee.iitb.ac.in>
On Mon, 11 Aug 2025 00:59:25 +0530 Akhilesh Patil wrote:
> Use standard string choices helper str_yes_no() to simplify
> arguments of dev_info() in enic_get_vnic_config().
> Avoid hardcoded multiple use of same string constants by using
> helper function achieving the same functionality.
This is unnecessary noise..
--
pw-bot: reject
prev parent reply other threads:[~2025-08-11 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 19:29 [PATCH] enic: use string choice helpers to simplify dev_info arguments Akhilesh Patil
2025-08-11 15:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811085648.449a605a@kernel.org \
--to=kuba@kernel.org \
--cc=akhilesh@ee.iitb.ac.in \
--cc=akhileshpatilvnit@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johndale@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).