* [PATCH net-next] Check in_sack firstly in tcp_match_skb_to_sack()
@ 2025-08-12 15:23 Xin Guo
2025-08-15 18:45 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Xin Guo @ 2025-08-12 15:23 UTC (permalink / raw)
To: ncardwell, edumazet, davem, dsahern, kuba, pabeni; +Cc: netdev, Xin Guo
This is because only when in_sack is equal to false
the pkt_len can be greater than or equal to skb->len,
so checking the in_sack firstly will make the logic
more clear.
Signed-off-by: Xin Guo <guoxin0309@gmail.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 71b76e98371a..293fb2cc8969 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1375,7 +1375,7 @@ static int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
pkt_len = new_len;
}
- if (pkt_len >= skb->len && !in_sack)
+ if (!in_sack && pkt_len >= skb->len)
return 0;
err = tcp_fragment(sk, TCP_FRAG_IN_RTX_QUEUE, skb,
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] Check in_sack firstly in tcp_match_skb_to_sack()
2025-08-12 15:23 [PATCH net-next] Check in_sack firstly in tcp_match_skb_to_sack() Xin Guo
@ 2025-08-15 18:45 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-08-15 18:45 UTC (permalink / raw)
To: Xin Guo; +Cc: ncardwell, edumazet, davem, dsahern, pabeni, netdev
On Tue, 12 Aug 2025 23:23:22 +0800 Xin Guo wrote:
> This is because only when in_sack is equal to false
> the pkt_len can be greater than or equal to skb->len,
> so checking the in_sack firstly will make the logic
> more clear.
no acks/review tags seem to be forthcoming so not sure this
is enough of an improvement to justify patching
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-15 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 15:23 [PATCH net-next] Check in_sack firstly in tcp_match_skb_to_sack() Xin Guo
2025-08-15 18:45 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).