From: Jakub Kicinski <kuba@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
danishanwar@ti.com, srk@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 8/9] net: ethernet: ti: am65-cpsw: add network flow classification support
Date: Wed, 13 Aug 2025 07:48:03 -0700 [thread overview]
Message-ID: <20250813074803.06db304a@kernel.org> (raw)
In-Reply-To: <d787ca03-a54e-46ae-828b-68fbd7b0b3a8@kernel.org>
On Wed, 13 Aug 2025 16:49:27 +0300 Roger Quadros wrote:
> On 17/05/2025 04:29, Jakub Kicinski wrote:
> > On Wed, 14 May 2025 15:04:28 +0300 Roger Quadros wrote:
> >> The TRM doesn't mention anything about order of evaluation of the
> >> classifier rules however it does mention in [1]
> >> "if multiple classifier matches occur, the highest match
> >> with thread enable bit set will be used."
> >
> > So we're not sure how to maintain the user requested ordering?
>
> Currently we are using the user/ethtool provided location as is.
>
> > Am I reading this correctly? If so then ..
> >
> >> + if (fs->location == RX_CLS_LOC_ANY ||
> >
> > .. why are we rejecting LOC_ANY?
>
> Because driver doesn't have logic to decide the location and relies on ethtool to
> decide it if user doesn't supply it.
The location supplied by the user may have semantic significance.
IOW locations may be interpreted as priorities.
It's better to support LOC_ANY and add the 10 lines of code to
allocate the id in the driver..
next prev parent reply other threads:[~2025-08-13 14:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 12:04 [PATCH net-next v4 0/9] net: ethernet: ti: am65-cpsw: add network flow classification support Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 1/9] net: ethernet: ti: cpsw_ale: Update Policer fields for more ALE size/ports Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 2/9] net: ethernet: ti: cpsw_ale: return ALE index in cpsw_ale_add_vlan() Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 3/9] net: ethernet: ti: cpsw_ale: return ALE index in cpsw_ale_vlan_add_modify() Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 4/9] net: ethernet: ti: cpsw_ale: return ALE index in cpsw_ale_add_ucast() Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 5/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_reset_entry() Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 6/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_set/clr_entry() Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 7/9] net: ethernet: ti: cpsw_ale: add policer save restore for PM sleep Roger Quadros
2025-05-14 12:04 ` [PATCH net-next v4 8/9] net: ethernet: ti: am65-cpsw: add network flow classification support Roger Quadros
2025-05-17 1:29 ` Jakub Kicinski
2025-08-13 13:49 ` Roger Quadros
2025-08-13 14:48 ` Jakub Kicinski [this message]
2025-08-14 13:44 ` Roger Quadros
2025-08-14 15:08 ` Jakub Kicinski
2025-05-14 12:04 ` [PATCH net-next v4 9/9] net: ethernet: ti: am65-cpsw: remove cpsw_ale_classifier_setup_default() Roger Quadros
2025-05-16 9:25 ` Simon Horman
2025-08-13 13:12 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813074803.06db304a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).