netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output
       [not found] <20250815000859.112169-1-sohammetha01@gmail.com>
@ 2025-08-15  0:17 ` Soham Metha
  2025-08-15  6:14   ` Florian Westphal
  0 siblings, 1 reply; 2+ messages in thread
From: Soham Metha @ 2025-08-15  0:17 UTC (permalink / raw)
  To: linux-kselftest
  Cc: shuah, skhan, linux-kernel-mentees, linux-kernel, Soham Metha,
	Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, netfilter-devel, coreteam, netdev

found/fixed following typos

- add add -> add
- cannnot -> cannot
- fowarded -> forwarded

in `tools/testing/selftests/net/netfilter/nft_nat.sh`

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 .../testing/selftests/net/netfilter/nft_nat.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/testing/selftests/net/netfilter/nft_nat.sh b/tools/testing/selftests/net/netfilter/nft_nat.sh
index a954754b99b3..44a8fdf5c19c 100755
--- a/tools/testing/selftests/net/netfilter/nft_nat.sh
+++ b/tools/testing/selftests/net/netfilter/nft_nat.sh
@@ -164,7 +164,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family dnat hook"
+		echo "SKIP: Could not add $family dnat hook"
 		return $ksft_skip
 	fi
 
@@ -239,7 +239,7 @@ EOF
 			test_inet_nat=false
 			return $ksft_skip
 		fi
-		echo "SKIP: Could not add add $family dnat hook"
+		echo "SKIP: Could not add $family dnat hook"
 		return $ksft_skip
 	fi
 
@@ -418,7 +418,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family masquerade hook"
+		echo "SKIP: Could not add $family masquerade hook"
 		return $ksft_skip
 	fi
 
@@ -509,7 +509,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family masquerade hook"
+		echo "SKIP: Could not add $family masquerade hook"
 		return $ksft_skip
 	fi
 
@@ -569,7 +569,7 @@ test_redirect6()
 	ip netns exec "$ns0" sysctl net.ipv6.conf.all.forwarding=1 > /dev/null
 
 	if ! ip netns exec "$ns2" ping -q -c 1 dead:1::99 > /dev/null;then
-		echo "ERROR: cannnot ping $ns1 from $ns2 via ipv6"
+		echo "ERROR: cannot ping $ns1 from $ns2 via ipv6"
 		lret=1
 	fi
 
@@ -598,7 +598,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family redirect hook"
+		echo "SKIP: Could not add $family redirect hook"
 		return $ksft_skip
 	fi
 
@@ -673,7 +673,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family redirect hook"
+		echo "SKIP: Could not add $family redirect hook"
 		return $ksft_skip
 	fi
 
@@ -844,7 +844,7 @@ table $family nat {
 }
 EOF
 	if [ $? -ne 0 ]; then
-		echo "SKIP: Could not add add $family masquerade hook"
+		echo "SKIP: Could not add $family masquerade hook"
 		return $ksft_skip
 	fi
 
@@ -859,7 +859,7 @@ EOF
 	# from router:service bypass connection tracking.
 	test_port_shadow_notrack "$family"
 
-	# test nat based mitigation: fowarded packets coming from service port
+	# test nat based mitigation: forwarded packets coming from service port
 	# are masqueraded with random highport.
 	test_port_shadow_pat "$family"
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output
  2025-08-15  0:17 ` [PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output Soham Metha
@ 2025-08-15  6:14   ` Florian Westphal
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2025-08-15  6:14 UTC (permalink / raw)
  To: Soham Metha
  Cc: linux-kselftest, shuah, skhan, linux-kernel-mentees, linux-kernel,
	Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
	netfilter-devel, coreteam, netdev

Soham Metha <sohammetha01@gmail.com> wrote:
> found/fixed following typos
> 
> - add add -> add
> - cannnot -> cannot
> - fowarded -> forwarded

OK, but what tree are you targetting?

In case netdev maintainers or someone else wants to take it:

Acked-by: Florian Westphal <fw@strlen.de>

Else we can route it via nf-next in the coming week.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-15  6:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20250815000859.112169-1-sohammetha01@gmail.com>
2025-08-15  0:17 ` [PATCH 2/6] setftests: net: netfilter: fix spelling mistakes in output Soham Metha
2025-08-15  6:14   ` Florian Westphal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).