From: Jakub Kicinski <kuba@kernel.org>
To: Xin Guo <guoxin0309@gmail.com>
Cc: ncardwell@google.com, edumazet@google.com, davem@davemloft.net,
dsahern@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] Check in_sack firstly in tcp_match_skb_to_sack()
Date: Fri, 15 Aug 2025 11:45:05 -0700 [thread overview]
Message-ID: <20250815114505.2d65b80e@kernel.org> (raw)
In-Reply-To: <20250812152322.19336-1-guoxin0309@gmail.com>
On Tue, 12 Aug 2025 23:23:22 +0800 Xin Guo wrote:
> This is because only when in_sack is equal to false
> the pkt_len can be greater than or equal to skb->len,
> so checking the in_sack firstly will make the logic
> more clear.
no acks/review tags seem to be forthcoming so not sure this
is enough of an improvement to justify patching
prev parent reply other threads:[~2025-08-15 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 15:23 [PATCH net-next] Check in_sack firstly in tcp_match_skb_to_sack() Xin Guo
2025-08-15 18:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815114505.2d65b80e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=guoxin0309@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).