From: Jakub Kicinski <kuba@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Xin Long <lucien.xin@gmail.com>, Paolo Abeni <pabeni@redhat.com>,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] sctp: Convert cookie authentication to use HMAC-SHA256
Date: Fri, 15 Aug 2025 18:06:17 -0700 [thread overview]
Message-ID: <20250815180617.0bc1b974@kernel.org> (raw)
In-Reply-To: <20250815215009.GA2041@quark>
On Fri, 15 Aug 2025 14:50:09 -0700 Eric Biggers wrote:
> > > It'd be great to get an ack / review from SCTP maintainers, otherwise
> > > we'll apply by Monday..
> > Other than that, LGTM.
> > Sorry for the late reply, I was running some SCTP-auth related tests
> > against the patchset.
>
> Ideally we'd just fail the write and remove the last mentions of md5 and
> sha1 from the code. But I'm concerned there could be a case where
> userspace is enabling cookie authentication by setting
> cookie_hmac_alg=md5 or cookie_hmac_alg=sha1, and by just failing the
> write the system would end up with cookie authentication not enabled.
>
> It would have been nice if this sysctl had just been a boolean toggle.
>
> A deprecation warning might be a good idea. How about the following on
> top of this patch:
No strong opinion but I find the deprecation warnings futile.
Chances are we'll be printing this until the end of time.
Either someone hard-cares and we'll need to revert, or nobody
does and we can deprecate today.
next prev parent reply other threads:[~2025-08-16 1:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 4:01 [PATCH net-next v2 0/3] sctp: Convert to use crypto lib, and upgrade cookie auth Eric Biggers
2025-08-13 4:01 ` [PATCH net-next v2 1/3] selftests: net: Explicitly enable CONFIG_CRYPTO_SHA1 for IPsec Eric Biggers
2025-08-13 4:01 ` [PATCH net-next v2 2/3] sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk authentication Eric Biggers
2025-08-13 4:01 ` [PATCH net-next v2 3/3] sctp: Convert cookie authentication to use HMAC-SHA256 Eric Biggers
2025-08-15 19:09 ` Jakub Kicinski
2025-08-15 21:19 ` Xin Long
2025-08-15 21:50 ` Eric Biggers
2025-08-16 1:06 ` Jakub Kicinski [this message]
2025-08-16 17:15 ` Xin Long
2025-08-18 15:43 ` Jakub Kicinski
2025-08-18 17:31 ` Eric Biggers
2025-08-18 17:41 ` Xin Long
2025-08-18 17:42 ` [PATCH net-next v2 0/3] sctp: Convert to use crypto lib, and upgrade cookie auth Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815180617.0bc1b974@kernel.org \
--to=kuba@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).