From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E942273D6D; Mon, 18 Aug 2025 19:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545932; cv=none; b=Xyc/PuQ6Qurm36Xcb4oza58RUaC6GRlBwQWafttxCuLWIIBo0vSmpA9kJhPdOU5urtK2xWKCql6zh0ZqEYo8t3R2l6V3Lfw6NEVLWEoGI5ist9sHkg12472aQG8pH0t/ZuBioIQXS5709J13S4BFxHdo7c4DY8aPBoTp3oaqZfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545932; c=relaxed/simple; bh=VkrdvVd5SEXtLNxlHzDFLtCsAV8AnNDaqUpaJZ60WSo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=moSFyMU+u5KF9kv/SGf9GDd/CGgXl6lE/2ZVLX50uOxZWbfsbtno1nOmlUtwAh8n5O5fgrcwOpjNqdQcyS9vb9g6BWcxrUgzVKRJQMmOBz2T1Kh4mfmO5CvfabG4CyY2vBVfcyebgPBzbnhOoHF4oByV7xlnpNOPNGFRkRIyXU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=elVAXFpI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="elVAXFpI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4719C4CEED; Mon, 18 Aug 2025 19:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755545931; bh=VkrdvVd5SEXtLNxlHzDFLtCsAV8AnNDaqUpaJZ60WSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=elVAXFpIRcifcL1F2/hmBDTQJ6fhrtmkcCHFaqwVx2qrap9TcXEw36jXWkzl3PcO4 qmFQ1Ha9zJToVhsw4TH7GzB7MbNgiP0z9CpZ674yoNNvx/R33Bkf9QhZ459iBjzxxD apBJoA11dnf9PKTsQaAC7IFHZUNcUwbJvVqm62DQubRSKd1U9uRZebN2g11ETnBGJC 8bPkk/oeJvWqcULZym1G2UXe6SRt4YrdRGnZZQjMM+ln8PkfYOmf+obrzX6NtXyuGC v2wB+EszDHEoKUCT509NrF/woTI7ViQuI0rJjVrDKFqBIKOzdtUJlHzZYZJphZ5Rts /lcTXZOG2+mDQ== Date: Mon, 18 Aug 2025 19:38:49 +0000 From: Eric Biggers To: Andrea Mayer Cc: netdev@vger.kernel.org, David Lebrun , stable@vger.kernel.org, stefano.salsano@uniroma2.it, Paolo Lungaroni Subject: Re: [PATCH net-next 1/3] ipv6: sr: Fix MAC comparison to be constant-time Message-ID: <20250818193849.GB12939@google.com> References: <20250816031136.482400-1-ebiggers@kernel.org> <20250816031136.482400-2-ebiggers@kernel.org> <20250818211607.c8eb87fbac2f81774022b54b@uniroma2.it> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250818211607.c8eb87fbac2f81774022b54b@uniroma2.it> On Mon, Aug 18, 2025 at 09:16:07PM +0200, Andrea Mayer wrote: > On Fri, 15 Aug 2025 20:11:34 -0700 > Eric Biggers wrote: > > > To prevent timing attacks, MACs need to be compared in constant time. > > Use the appropriate helper function for this. > > > > Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") > > Cc: stable@vger.kernel.org > > Signed-off-by: Eric Biggers > > --- > > net/ipv6/seg6_hmac.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Hi Eric, > > Thanks for the fix! > > I believe it would be best to submit this fix separately from the current patch > set. Since this addresses a bug rather than an enhancement or cleanup, sending > it individually with the 'net' tag will help facilitate applying this patch to > the net tree. > > Ciao, > Andrea Then there would be a merge conflict between the two patchsets. I can do that if you want, but then I'd probably have to wait for this patch to reach net-next before the rest can proceed. - Eric