netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: net: bpf_offload: print loaded programs on mismatch
@ 2025-08-19  7:33 Hangbin Liu
  2025-08-21  2:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Hangbin Liu @ 2025-08-19  7:33 UTC (permalink / raw)
  To: netdev
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Alexei Starovoitov, Daniel Borkmann, Jesper Dangaard Brouer,
	John Fastabend, Sebastian Andrzej Siewior, Lorenzo Bianconi,
	Andrii Nakryiko, Jussi Maki, Jay Vosburgh, Andy Gospodarek,
	Jonathan Corbet, Andrew Lunn, Nikolay Aleksandrov,
	Toke Høiland-Jørgensen, Simon Horman, Felix Maurer,
	Viktor Malik, linux-kernel, bpf, Hangbin Liu

The test sometimes fails due to an unexpected number of loaded programs. e.g

  FAIL: 2 BPF programs loaded, expected 1
    File "/usr/libexec/kselftests/net/./bpf_offload.py", line 940, in <module>
      progs = bpftool_prog_list(expected=1)
    File "/usr/libexec/kselftests/net/./bpf_offload.py", line 187, in bpftool_prog_list
      fail(True, "%d BPF programs loaded, expected %d" %
    File "/usr/libexec/kselftests/net/./bpf_offload.py", line 89, in fail
      tb = "".join(traceback.extract_stack().format())

However, the logs do not show which programs were actually loaded, making it
difficult to debug the failure.

Add printing of the loaded programs when a mismatch is detected to help
troubleshoot such errors. The list is printed on a new line to avoid breaking
the current log format.

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/bpf_offload.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/bpf_offload.py b/tools/testing/selftests/net/bpf_offload.py
index b2c271b79240..c856d266c8f3 100755
--- a/tools/testing/selftests/net/bpf_offload.py
+++ b/tools/testing/selftests/net/bpf_offload.py
@@ -184,8 +184,8 @@ def bpftool_prog_list(expected=None, ns="", exclude_orphaned=True):
         progs = [ p for p in progs if not p['orphaned'] ]
     if expected is not None:
         if len(progs) != expected:
-            fail(True, "%d BPF programs loaded, expected %d" %
-                 (len(progs), expected))
+            fail(True, "%d BPF programs loaded, expected %d\nLoaded Progs:\n%s" %
+                 (len(progs), expected, pp.pformat(progs)))
     return progs
 
 def bpftool_map_list(expected=None, ns=""):
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] selftests: net: bpf_offload: print loaded programs on mismatch
  2025-08-19  7:33 [PATCH net-next] selftests: net: bpf_offload: print loaded programs on mismatch Hangbin Liu
@ 2025-08-21  2:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-08-21  2:40 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: netdev, davem, edumazet, kuba, pabeni, ast, daniel, hawk,
	john.fastabend, bigeasy, lorenzo, andriin, joamaki, jv, andy,
	corbet, andrew+netdev, razor, toke, horms, fmaurer, vmalik,
	linux-kernel, bpf

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 19 Aug 2025 07:33:48 +0000 you wrote:
> The test sometimes fails due to an unexpected number of loaded programs. e.g
> 
>   FAIL: 2 BPF programs loaded, expected 1
>     File "/usr/libexec/kselftests/net/./bpf_offload.py", line 940, in <module>
>       progs = bpftool_prog_list(expected=1)
>     File "/usr/libexec/kselftests/net/./bpf_offload.py", line 187, in bpftool_prog_list
>       fail(True, "%d BPF programs loaded, expected %d" %
>     File "/usr/libexec/kselftests/net/./bpf_offload.py", line 89, in fail
>       tb = "".join(traceback.extract_stack().format())
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: net: bpf_offload: print loaded programs on mismatch
    https://git.kernel.org/netdev/net-next/c/eacb6e408dc8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-21  2:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19  7:33 [PATCH net-next] selftests: net: bpf_offload: print loaded programs on mismatch Hangbin Liu
2025-08-21  2:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).