Re: [PATCH V2 net 4/8] net/mlx5: Destroy vport QoS element when no configuration remains

Przemek Kitszel
2025-08-20T14:45:58Z

On 8/20/25 15:32, Mark Bloch wrote:
> From: Carolina Jubran <cjubran@nvidia.com>
>
> If a VF has been configured and the user later clears all QoS settings,
> the vport element remains in the firmware QoS tree. This leads to
> inconsistent behavior compared to VFs that were never configured, since
> the FW assumes that unconfigured VFs are outside the QoS hierarchy.
> As a result, the bandwidth share across VFs may differ, even though
> none of them appear to have any configuration.
>
> Align the driver behavior with the FW expectation by destroying the
> vport QoS element when all configurations are removed.
>
> Fixes: c9497c98901c ("net/mlx5: Add support for setting VF min rate")
> Fixes: cf7e73770d1b ("net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw")
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Signed-off-by: Mark Bloch <mbloch@nvidia.com>
> ---
> .../net/ethernet/mellanox/mlx5/core/esw/qos.c | 57 ++++++++++++++++---
> 1 file changed, 49 insertions(+), 8 deletions(-)
this is much better, thank you!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>