From: Stefano Brivio <sbrivio@redhat.com>
To: Florian Westphal <fw@strlen.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
<netfilter-devel@vger.kernel.org>,
pablo@netfilter.org
Subject: Re: [PATCH net-next 5/6] netfilter: nft_set_pipapo: Store real pointer, adjust later.
Date: Wed, 20 Aug 2025 17:44:01 +0200 [thread overview]
Message-ID: <20250820174401.5addbfc1@elisabeth> (raw)
In-Reply-To: <20250820144738.24250-6-fw@strlen.de>
On Wed, 20 Aug 2025 16:47:37 +0200
Florian Westphal <fw@strlen.de> wrote:
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> The struct nft_pipapo_scratch is allocated, then aligned to the required
> alignment and difference (in bytes) is then saved in align_off. The
> aligned pointer is used later.
> While this works, it gets complicated with all the extra checks if
> all member before map are larger than the required alignment.
>
> Instead of saving the aligned pointer, just save the returned pointer
> and align the map pointer in nft_pipapo_lookup() before using it. The
> alignment later on shouldn't be that expensive.
The cost of doing the alignment later was the very reason why I added
this whole dance in the first place though. Did you check packet
matching rates before and after this?
--
Stefano
next prev parent reply other threads:[~2025-08-20 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 14:47 [PATCH net-next 0/6] netfilter: updates for net-next Florian Westphal
2025-08-20 14:47 ` [PATCH net-next 1/6] netfilter: ctnetlink: remove refcounting in dying list dumping Florian Westphal
2025-08-22 0:30 ` patchwork-bot+netdevbpf
2025-08-20 14:47 ` [PATCH net-next 2/6] netfilter: nft_set_pipapo_avx2: Drop the comment regarding protection Florian Westphal
2025-08-20 14:47 ` [PATCH net-next 3/6] netfilter: nft_set_pipapo_avx2: split lookup function in two parts Florian Westphal
2025-08-20 14:47 ` [PATCH net-next 4/6] netfilter: nft_set_pipapo: use avx2 algorithm for insertions too Florian Westphal
2025-08-20 15:45 ` Stefano Brivio
2025-08-20 14:47 ` [PATCH net-next 5/6] netfilter: nft_set_pipapo: Store real pointer, adjust later Florian Westphal
2025-08-20 15:44 ` Stefano Brivio [this message]
2025-08-20 16:01 ` Sebastian Andrzej Siewior
2025-08-20 16:15 ` Stefano Brivio
2025-08-20 16:29 ` Sebastian Andrzej Siewior
2025-08-20 16:34 ` Stefano Brivio
2025-08-20 21:04 ` Stefano Brivio
2025-08-21 6:37 ` Sebastian Andrzej Siewior
2025-08-20 14:47 ` [PATCH net-next 6/6] netfilter: nft_set_pipapo: Use nested-BH locking for nft_pipapo_scratch Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820174401.5addbfc1@elisabeth \
--to=sbrivio@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox