From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: <almasrymina@google.com>, <asml.silence@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
<cratiu@nvidia.com>, <parav@nvidia.com>, <netdev@vger.kernel.org>,
<sdf@meta.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 6/7] net: devmem: pre-read requested rx queues during bind
Date: Wed, 20 Aug 2025 18:09:04 -0700 [thread overview]
Message-ID: <20250820180904.698f1546@kernel.org> (raw)
In-Reply-To: <20250820171214.3597901-8-dtatulea@nvidia.com>
On Wed, 20 Aug 2025 20:11:57 +0300 Dragos Tatulea wrote:
> struct nlattr *tb[ARRAY_SIZE(netdev_queue_id_nl_policy)];
> + struct nlattr *attr;
> + int rem, err = 0;
> + u32 rxq_idx;
> +
> + nla_for_each_attr_type(attr, NETDEV_A_DMABUF_QUEUES,
> + genlmsg_data(info->genlhdr),
> + genlmsg_len(info->genlhdr), rem) {
> + err = nla_parse_nested(
> + tb, ARRAY_SIZE(netdev_queue_id_nl_policy) - 1, attr,
While you're touching this line, could you perhaps clean up the line
wrap? Save ARRAY_SIZE(netdev_queue_id_nl_policy) - 1 to a const and
then:
err = nla_parse_nested(tb, maxtype, attr,
netdev_queue_id_nl_policy, info->extack);
or some such.
next prev parent reply other threads:[~2025-08-21 1:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 17:11 [PATCH net-next v4 0/7] devmem/io_uring: allow more flexibility for ZC DMA devices Dragos Tatulea
2025-08-20 17:11 ` [PATCH net-next v4 1/7] queue_api: add support for fetching per queue DMA dev Dragos Tatulea
2025-08-20 22:48 ` Mina Almasry
2025-08-21 1:01 ` Jakub Kicinski
2025-08-21 11:06 ` Dragos Tatulea
2025-08-20 17:11 ` [PATCH net-next v4 2/7] io_uring/zcrx: add support for custom DMA devices Dragos Tatulea
2025-08-20 17:11 ` [PATCH net-next v4 3/7] net: devmem: get netdev DMA device via new API Dragos Tatulea
2025-08-21 1:04 ` Jakub Kicinski
2025-08-20 17:11 ` [PATCH net-next v4 4/7] net/mlx5e: add op for getting netdev DMA device Dragos Tatulea
2025-08-20 17:11 ` [PATCH net-next v4 5/7] net: devmem: pull out dma_dev out of net_devmem_bind_dmabuf Dragos Tatulea
2025-08-20 17:11 ` [PATCH net-next v4 6/7] net: devmem: pre-read requested rx queues during bind Dragos Tatulea
2025-08-20 22:51 ` Mina Almasry
2025-08-21 1:09 ` Jakub Kicinski [this message]
2025-08-21 11:07 ` Dragos Tatulea
2025-08-20 17:11 ` [PATCH net-next v4 7/7] net: devmem: allow binding on rx queues with same DMA devices Dragos Tatulea
2025-08-20 22:57 ` Mina Almasry
2025-08-21 16:37 ` Dragos Tatulea
2025-08-21 1:16 ` Jakub Kicinski
2025-08-21 11:10 ` Dragos Tatulea
2025-08-21 14:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820180904.698f1546@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=sdf@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).