From: Stefano Brivio <sbrivio@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [PATCH net-next 5/6] netfilter: nft_set_pipapo: Store real pointer, adjust later.
Date: Wed, 20 Aug 2025 18:34:51 +0200 [thread overview]
Message-ID: <20250820183451.6b4749d6@elisabeth> (raw)
In-Reply-To: <20250820162925.CWZJJo36@linutronix.de>
On Wed, 20 Aug 2025 18:29:25 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 2025-08-20 18:15:36 [+0200], Stefano Brivio wrote:
> > > As far as I remember the alignment code expects that the "hole" at the
> > > begin does not exceed a certain size and the lock there exceeds it.
> >
> > I think you're right. But again, the alignment itself should be fast,
> > that's not what I'm concerned about.
>
> Are we good are do you want me to do the performance check, that you
> suggested?
I think it would be good if you could give that a try (I don't have a
stable setup to run that at hand right now, sorry). It shouldn't take
long.
That's because I'm not sure how cached accesses are affected by this
(see just above in my previous email).
--
Stefano
next prev parent reply other threads:[~2025-08-20 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 14:47 [PATCH net-next 0/6] netfilter: updates for net-next Florian Westphal
2025-08-20 14:47 ` [PATCH net-next 1/6] netfilter: ctnetlink: remove refcounting in dying list dumping Florian Westphal
2025-08-22 0:30 ` patchwork-bot+netdevbpf
2025-08-20 14:47 ` [PATCH net-next 2/6] netfilter: nft_set_pipapo_avx2: Drop the comment regarding protection Florian Westphal
2025-08-20 14:47 ` [PATCH net-next 3/6] netfilter: nft_set_pipapo_avx2: split lookup function in two parts Florian Westphal
2025-08-20 14:47 ` [PATCH net-next 4/6] netfilter: nft_set_pipapo: use avx2 algorithm for insertions too Florian Westphal
2025-08-20 15:45 ` Stefano Brivio
2025-08-20 14:47 ` [PATCH net-next 5/6] netfilter: nft_set_pipapo: Store real pointer, adjust later Florian Westphal
2025-08-20 15:44 ` Stefano Brivio
2025-08-20 16:01 ` Sebastian Andrzej Siewior
2025-08-20 16:15 ` Stefano Brivio
2025-08-20 16:29 ` Sebastian Andrzej Siewior
2025-08-20 16:34 ` Stefano Brivio [this message]
2025-08-20 21:04 ` Stefano Brivio
2025-08-21 6:37 ` Sebastian Andrzej Siewior
2025-08-20 14:47 ` [PATCH net-next 6/6] netfilter: nft_set_pipapo: Use nested-BH locking for nft_pipapo_scratch Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820183451.6b4749d6@elisabeth \
--to=sbrivio@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).