* [PATCH net-next] net: vxlan: remove unused argument of vxlan_mdb_remote_fini()
@ 2025-08-20 6:56 Wang Liang
2025-08-20 11:57 ` Ido Schimmel
0 siblings, 1 reply; 3+ messages in thread
From: Wang Liang @ 2025-08-20 6:56 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, jiri, wangliang74,
idosch, rrendec, menglong8.dong
Cc: yuehaibing, zhangchangzhong, netdev, linux-kernel
The argument 'vxlan' is unused, when commit a3a48de5eade ("vxlan: mdb: Add
MDB control path support") add function vxlan_mdb_remote_fini(). Just
remove it.
Signed-off-by: Wang Liang <wangliang74@huawei.com>
---
drivers/net/vxlan/vxlan_mdb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vxlan/vxlan_mdb.c b/drivers/net/vxlan/vxlan_mdb.c
index 816ab1aa0526..e8fa9364d661 100644
--- a/drivers/net/vxlan/vxlan_mdb.c
+++ b/drivers/net/vxlan/vxlan_mdb.c
@@ -740,8 +740,7 @@ static int vxlan_mdb_remote_init(const struct vxlan_mdb_config *cfg,
return 0;
}
-static void vxlan_mdb_remote_fini(struct vxlan_dev *vxlan,
- struct vxlan_mdb_remote *remote)
+static void vxlan_mdb_remote_fini(struct vxlan_mdb_remote *remote)
{
WARN_ON_ONCE(!hlist_empty(&remote->src_list));
vxlan_mdb_remote_rdst_fini(rtnl_dereference(remote->rd));
@@ -1159,7 +1158,7 @@ static int vxlan_mdb_remote_add(const struct vxlan_mdb_config *cfg,
return 0;
err_remote_fini:
- vxlan_mdb_remote_fini(cfg->vxlan, remote);
+ vxlan_mdb_remote_fini(remote);
err_free_remote:
kfree(remote);
return err;
@@ -1172,7 +1171,7 @@ static void vxlan_mdb_remote_del(struct vxlan_dev *vxlan,
vxlan_mdb_remote_notify(vxlan, mdb_entry, remote, RTM_DELMDB);
list_del_rcu(&remote->list);
vxlan_mdb_remote_srcs_del(vxlan, &mdb_entry->key, remote);
- vxlan_mdb_remote_fini(vxlan, remote);
+ vxlan_mdb_remote_fini(remote);
kfree_rcu(remote, rcu);
}
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: vxlan: remove unused argument of vxlan_mdb_remote_fini()
2025-08-20 6:56 [PATCH net-next] net: vxlan: remove unused argument of vxlan_mdb_remote_fini() Wang Liang
@ 2025-08-20 11:57 ` Ido Schimmel
2025-08-21 22:51 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Ido Schimmel @ 2025-08-20 11:57 UTC (permalink / raw)
To: Wang Liang
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, jiri, rrendec,
menglong8.dong, yuehaibing, zhangchangzhong, netdev, linux-kernel
On Wed, Aug 20, 2025 at 02:56:16PM +0800, Wang Liang wrote:
> The argument 'vxlan' is unused, when commit a3a48de5eade ("vxlan: mdb: Add
> MDB control path support") add function vxlan_mdb_remote_fini(). Just
> remove it.
>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
OK, but personally I wouldn't bother with such patches unless they are a
part of a larger body of work.
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: vxlan: remove unused argument of vxlan_mdb_remote_fini()
2025-08-20 11:57 ` Ido Schimmel
@ 2025-08-21 22:51 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-08-21 22:51 UTC (permalink / raw)
To: Wang Liang
Cc: Ido Schimmel, andrew+netdev, davem, edumazet, pabeni, jiri,
rrendec, menglong8.dong, yuehaibing, zhangchangzhong, netdev,
linux-kernel
On Wed, 20 Aug 2025 14:57:47 +0300 Ido Schimmel wrote:
> On Wed, Aug 20, 2025 at 02:56:16PM +0800, Wang Liang wrote:
> > The argument 'vxlan' is unused, when commit a3a48de5eade ("vxlan: mdb: Add
> > MDB control path support") add function vxlan_mdb_remote_fini(). Just
> > remove it.
> >
> > Signed-off-by: Wang Liang <wangliang74@huawei.com>
>
> OK, but personally I wouldn't bother with such patches unless they are a
> part of a larger body of work.
+1, I'll drop this.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-21 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 6:56 [PATCH net-next] net: vxlan: remove unused argument of vxlan_mdb_remote_fini() Wang Liang
2025-08-20 11:57 ` Ido Schimmel
2025-08-21 22:51 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).