From: Jakub Kicinski <kuba@kernel.org>
To: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
taniya.das@oss.qualcomm.com, imran.shaik@oss.qualcomm.com,
quic_vbadigan@quicinc.com, quic_mrana@quicinc.com
Subject: Re: [PATCH 5/5] bus: mhi: host: mhi_phc: Add support for PHC over MHI
Date: Thu, 21 Aug 2025 18:02:47 -0700 [thread overview]
Message-ID: <20250821180247.29d0f4b3@kernel.org> (raw)
In-Reply-To: <20250818-tsc_time_sync-v1-5-2747710693ba@oss.qualcomm.com>
On Mon, 18 Aug 2025 12:25:50 +0530 Krishna Chaitanya Chundru wrote:
> This patch introduces the MHI PHC (PTP Hardware Clock) driver, which
> registers a PTP (Precision Time Protocol) clock and communicates with
> the MHI core to get the device side timestamps. These timestamps are
> then exposed to the PTP subsystem, enabling precise time synchronization
> between the host and the device.
> +static struct ptp_clock_info qcom_ptp_clock_info = {
> + .owner = THIS_MODULE,
> + .gettimex64 = qcom_ptp_gettimex64,
> +};
Yet another device to device clock sync driver. Please see the
discussion here:
https://lore.kernel.org/all/20250815113814.5e135318@kernel.org/
I think we have a consensus within the community that we should
stop cramming random clocks into the PTP subsystem.
Exporting read-only clocks from another processor is not what PTP
is for.
prev parent reply other threads:[~2025-08-22 1:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 6:55 [PATCH 0/5] bus: mhi: host: mhi_phc: Add support for PHC over MHI Krishna Chaitanya Chundru
2025-08-18 6:55 ` [PATCH 1/5] bus: mhi: host: Add support for non-posted TSC timesync feature Krishna Chaitanya Chundru
2025-08-18 6:55 ` [PATCH 2/5] bus: mhi: host: Add support for 64bit register reads and writes Krishna Chaitanya Chundru
2025-08-18 6:55 ` [PATCH 3/5] bus: mhi: pci_generic: Add support for 64 bit register read & write Krishna Chaitanya Chundru
2025-08-18 6:55 ` [PATCH 4/5] bus: mhi: host: Update the Time sync logic to read 64 bit register value Krishna Chaitanya Chundru
2025-09-02 9:14 ` Konrad Dybcio
2025-08-18 6:55 ` [PATCH 5/5] bus: mhi: host: mhi_phc: Add support for PHC over MHI Krishna Chaitanya Chundru
2025-08-22 1:02 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821180247.29d0f4b3@kernel.org \
--to=kuba@kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).