From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81CDD371EB5 for ; Thu, 21 Aug 2025 20:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806911; cv=none; b=pr9sxNWqg/KdX5frUqDXUtqJ9fIVkTrw/kEQ2rzpM9iqJCai0DVpmfm0hDStm6TegJK4q2xWA7TiVNT/M/WgYnq0hlLNk803MKBfC3cnOAEmK8DaeC4vvAXms6OJx7lF1ZainZtLpfq+HJsUxiDegVcPpFSHQCKb4K3onxmzsGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806911; c=relaxed/simple; bh=E88hXeAEs+yXdxHqIfTWo/GvQIeDr+kkFObDidynu1s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kZXM8M7xoQunPkyZYIJ+WpFHRWpeNJAQdYYrHoY7CCTfvWl2L4hN0bbEZKpwNha4cfCsDUTTFw+UA6LixEqFRD6/AhUL1FCjXJf0i4Svyr/6fn3mnHPTVkn9s3es4qpB2eYIzDYUkUUOdao5v4wTGWXBs/m8Vt7FYZiK18Rm+Gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=emJiYsQh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="emJiYsQh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w6VkvDa+3msZeC5nA9B9+aDln+Mg2ABReefULBX94/4=; b=emJiYsQhLO/NT4Olpz2Bg6AOu4KEWiS4PUBiOVdpi0RKUk2K+I+Qtab+VTbE2ktDP56B44 WFNeuJ/XA8tqdWTyT1ZtLV2gVwe7fhukm7L15QPMQcNc7vtO4Gd/Wlj62lhoZNeGyLCi1V TMtyL8O6385LKaojVp5y1xb7w01XjF0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326-pCI0iKMXMVymK97WtdFFlQ-1; Thu, 21 Aug 2025 16:08:05 -0400 X-MC-Unique: pCI0iKMXMVymK97WtdFFlQ-1 X-Mimecast-MFC-AGG-ID: pCI0iKMXMVymK97WtdFFlQ_1755806880 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45a15f10f31so14273745e9.0 for ; Thu, 21 Aug 2025 13:08:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806880; x=1756411680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w6VkvDa+3msZeC5nA9B9+aDln+Mg2ABReefULBX94/4=; b=w4qgVD4lOSwov22lt/q/Sz1BN2fD+C4fXUvhpS0Q6gqINJcK11qpTAnUDrbHT6q1uv t75OJk2ohorWGzFKHel6ThjTs4etTb0Xa0clVWHOJaPzmFgN/T5uUM9epEicJnKKXjSo 3Qynw64eXgZxNnqn+JMzzExK74SEY+nOWLamJEqsMyWFJOi3iayHIJIfnXCvccRz89Lo rDkkrE3Rzb+pbHZLtyAZNkCiqEOdHQTNXQFjHPIM+rBTakie73G8SKqlNcLZKbnobfyO Z/klejqKTttYUilB6Nv+nMhR1PEo4PSlaO4W0BvmdncxpD2VSubg6KIhh5L5gW4NT4rc Swbg== X-Forwarded-Encrypted: i=1; AJvYcCXOo66yjAhq//1yc1OwuUnkVS2/WE6lgLgWalPujt9dnr/MFTbJsu7CIusjHMhg1IVnVkk4pvQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz093OBqWt3BHhaAfD7RZ6635bf43EzQR45GDMkNi1PXhfcmCwq fE/t59BUVOceqfGMPC6tF0iuzwcN46DPIe7gq7heAOpO826M0nOK5cy9RM+jOvZLo3zIkKACpk0 zDLPH74liQwsY2b75Ow0gyltLCR9GsmlDtbRx3ceFWovnc0O5MRQlguCzoQ== X-Gm-Gg: ASbGnctuVYtNpYHtD237lZKvJWm2Lz8GAOeRzVA65fPqXApBEv3dJXXgCuagWCNrMxD uI8gpTg5q8AT50WfqAA43vQrsPRocEyCNkinp4zbRB+SgAZ4YMhocx4ff4TSeUIVD1Vsz+hl9LM lbPJLPhl9E8T7aSdcnDmZknKV+oXFaVsFtknzUl7tsiZXAuMriSQgtVds4CfwfOuAm/ZrldmNRH LzWpyZTmwf9hGRMxVoS8tEdhwCNAruyKwVYl1vB4iEfJzRZpc7Rtp3jwn+c7/UusFsIoQW7i0Tp J/aErDOR6UGKV+uVNEq7/MCrNAR+wUjROt9904hswbTL5M5FD+g49x4uyx9g16apyIzopNBjO7L d83+LGnyJegsOU17haae1ng== X-Received: by 2002:a05:600c:1c87:b0:456:942:b162 with SMTP id 5b1f17b1804b1-45b51792539mr3328855e9.11.1755806880059; Thu, 21 Aug 2025 13:08:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9ciI0WdoI3CxhUtu7m/cESVsdReJmvmXFWCMaWsO+hhXySreox2GeOL2sJ8kVyLPwCYhbEA== X-Received: by 2002:a05:600c:1c87:b0:456:942:b162 with SMTP id 5b1f17b1804b1-45b51792539mr3328365e9.11.1755806879543; Thu, 21 Aug 2025 13:07:59 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c07778939bsm12219075f8f.46.2025.08.21.13.07.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:07:59 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Jens Axboe , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 19/35] io_uring/zcrx: remove nth_page() usage within folio Date: Thu, 21 Aug 2025 22:06:45 +0200 Message-ID: <20250821200701.1329277-20-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Within a folio/compound page, nth_page() is no longer required. Given that we call folio_test_partial_kmap()+kmap_local_page(), the code would already be problematic if the src_pages would span multiple folios. So let's just assume that all src pages belong to a single folio/compound page and can be iterated ordinarily. Cc: Jens Axboe Signed-off-by: David Hildenbrand --- io_uring/zcrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c index f29b2a4867516..107b2a1b31c1c 100644 --- a/io_uring/zcrx.c +++ b/io_uring/zcrx.c @@ -966,7 +966,7 @@ static ssize_t io_copy_page(struct page *dst_page, struct page *src_page, size_t n = len; if (folio_test_partial_kmap(page_folio(src_page))) { - src_page = nth_page(src_page, src_offset / PAGE_SIZE); + src_page += src_offset / PAGE_SIZE; src_offset = offset_in_page(src_offset); n = min(PAGE_SIZE - src_offset, PAGE_SIZE - dst_offset); n = min(n, len); -- 2.50.1