public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Qingjie Xing <xqjcool@gmail.com>
To: fw@strlen.de
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, xqjcool@gmail.com
Subject: Re: [PATCH] netfilter: conntrack: drop expectations before freeing templates
Date: Thu, 21 Aug 2025 18:17:56 -0700	[thread overview]
Message-ID: <20250822011756.3264808-1-xqjcool@gmail.com> (raw)
In-Reply-To: <aKbIUQ3a3jqijZi0@strlen.de>

Thanks for the careful review and the pointers.

I dug deeper and found the root cause on my side: there was leftover/out-of-tree
 code in my local tree that could attach the per-rule template to skb->_nfct. 
After cleaning up those remnants, upstream behavior matches your description—
nf_conntrack_in() clears any template, tftp_help() sees a real conntrack, 
and I can no longer reproduce the crash.

Apologies for the noise and for any time this cost you. I’ll withdraw the patch 
as it was addressing a problem introduced by my local changes. 

Thanks again for the guidance.

      reply	other threads:[~2025-08-22  1:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 18:17 [PATCH] netfilter: conntrack: drop expectations before freeing templates Qingjie Xing
2025-08-19 18:27 ` Florian Westphal
2025-08-19 23:24   ` Qingjie Xing
2025-08-20  0:17     ` Florian Westphal
2025-08-20  0:24       ` Florian Westphal
2025-08-20 18:32         ` Qingjie Xing
2025-08-21  7:18           ` Florian Westphal
2025-08-22  1:17             ` Qingjie Xing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250822011756.3264808-1-xqjcool@gmail.com \
    --to=xqjcool@gmail.com \
    --cc=fw@strlen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox