From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Lukasz Majewski <lukma@denx.de>, Jonathan Corbet <corbet@lwn.net>,
Donald Hunter <donald.hunter@gmail.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Jiri Pirko <jiri@resnulli.us>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Divya.Koppera@microchip.com, Sabrina Dubroca <sd@queasysnail.net>,
Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH net-next v3 3/3] Documentation: net: add flow control guide and document ethtool API
Date: Fri, 22 Aug 2025 17:19:21 +0300 [thread overview]
Message-ID: <20250822141921.rlii3dnblodqezrc@skbuf> (raw)
In-Reply-To: <aKheqhfqht1Cx31M@pengutronix.de>
On Fri, Aug 22, 2025 at 02:12:26PM +0200, Oleksij Rempel wrote:
> > > +The optimal values for these thresholds depend on the link's round-trip-time
> > > +(RTT) and the peer's internal processing latency. The high water mark must be
> > > +set low enough so that the MAC's RX FIFO does not overflow while waiting for
> > > +the peer to react to the PAUSE frame. The driver is responsible for configuring
> > > +sensible defaults according to the IEEE specification. User tuning should only
> > > +be necessary in special cases, such as on links with unusually long cable
> > > +lengths (e.g., long-haul fiber).
> >
> > How would user tuning be achieved?
>
> Do you mean how such tuning could be exposed to user space (e.g. via
> ethtool/sysfs), or rather whether it makes sense to provide a user
> interface for this at all, since drivers normally set safe defaults?
Sorry for not being clear. I think that by saying that user tuning
should only be necessary in certain cases, you're giving the impression
that it's supported in current API. You might want to clarify that it's
not.
Also, I'm not sure that the length of the cable runs would be a factor
in tuning the flow control watermarks, do you have a reference for that?
I'm mentally debating the value of the last sentence.
prev parent reply other threads:[~2025-08-22 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 13:10 [PATCH net-next v3 0/3] Documentation and ynl: add flow control Oleksij Rempel
2025-08-20 13:10 ` [PATCH net-next v3 1/3] tools: ynl-gen: generate kdoc for attribute enums Oleksij Rempel
2025-08-20 13:10 ` [PATCH net-next v3 2/3] net: ynl: add generated kdoc to UAPI headers Oleksij Rempel
2025-08-22 14:11 ` ALOK TIWARI
2025-08-24 8:10 ` Oleksij Rempel
2025-08-25 17:01 ` Jakub Kicinski
2025-08-20 13:10 ` [PATCH net-next v3 3/3] Documentation: net: add flow control guide and document ethtool API Oleksij Rempel
2025-08-22 11:35 ` Vladimir Oltean
2025-08-22 12:12 ` Oleksij Rempel
2025-08-22 14:19 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822141921.rlii3dnblodqezrc@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=Divya.Koppera@microchip.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hawk@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sd@queasysnail.net \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox