From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
almasrymina@google.com, sdf@fomichev.me, joe@dama.to,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] selftests: drv-net: ncdevmem: configure and restore HDS threshold
Date: Fri, 22 Aug 2025 15:34:29 -0700 [thread overview]
Message-ID: <20250822153429.4e6829b4@kernel.org> (raw)
In-Reply-To: <aKjunRT-rmsd8tLH@mini-arch>
On Fri, 22 Aug 2025 15:26:37 -0700 Stanislav Fomichev wrote:
> > @@ -436,8 +490,14 @@ static int configure_headersplit(bool on)
> >
> > req = ethtool_rings_set_req_alloc();
> > ethtool_rings_set_req_set_header_dev_index(req, ifindex);
> > - /* 0 - off, 1 - auto, 2 - on */
> > - ethtool_rings_set_req_set_tcp_data_split(req, on ? 2 : 0);
> > + if (on) {
> > + ethtool_rings_set_req_set_tcp_data_split(req,
> > + ETHTOOL_TCP_DATA_SPLIT_ENABLED);
> > + ethtool_rings_set_req_set_hds_thresh(req, 0);
>
> From talking to Taehee awhile ago it seemed like unconditionally
> setting 0 will fail on the devices that don't support it.
> Is it not the case anymore with ethnl_set_rings_validate?
Good point! ring params are validated against the supported attr flags.
We can pass in config here and only set hds_thresh if max was reported.
That should mean driver supports the setting.
prev parent reply other threads:[~2025-08-22 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 20:00 [PATCH net-next 0/4] selftests: drv-net: ncdevmem: fix error paths Jakub Kicinski
2025-08-22 20:00 ` [PATCH net-next 1/4] selftests: drv-net: ncdevmem: remove use of error() Jakub Kicinski
2025-08-22 21:25 ` Stanislav Fomichev
2025-08-22 20:00 ` [PATCH net-next 2/4] selftests: drv-net: ncdevmem: save IDs of flow rules we added Jakub Kicinski
2025-08-22 21:27 ` Stanislav Fomichev
2025-08-22 22:15 ` Jakub Kicinski
2025-08-22 20:00 ` [PATCH net-next 3/4] selftests: drv-net: ncdevmem: restore old channel config Jakub Kicinski
2025-08-22 22:14 ` Stanislav Fomichev
2025-08-22 20:00 ` [PATCH net-next 4/4] selftests: drv-net: ncdevmem: configure and restore HDS threshold Jakub Kicinski
2025-08-22 22:26 ` Stanislav Fomichev
2025-08-22 22:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822153429.4e6829b4@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).