From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
przemyslaw.kitszel@intel.com, dawid.osuchowski@linux.intel.com
Subject: Re: [PATCH iwl-next v2 00/15] Fwlog support in ixgbe
Date: Tue, 26 Aug 2025 14:48:51 +0100 [thread overview]
Message-ID: <20250826134851.GA5892@horms.kernel.org> (raw)
In-Reply-To: <20250812042337.1356907-1-michal.swiatkowski@linux.intel.com>
On Tue, Aug 12, 2025 at 06:23:21AM +0200, Michal Swiatkowski wrote:
> Hi,
>
> Firmware logging is a feature that allow user to dump firmware log using
> debugfs interface. It is supported on device that can handle specific
> firmware ops. It is true for ice and ixgbe driver.
>
> Prepare code from ice driver to be moved to the library code and reuse
> it in ixgbe driver.
>
> v1 --> v2: [1]
> * fix building issue in patch 9
>
> [1] https://lore.kernel.org/netdev/20250722104600.10141-1-michal.swiatkowski@linux.intel.com/
>
> Michal Swiatkowski (15):
> ice: make fwlog functions static
> ice: move get_fwlog_data() to fwlog file
> ice: drop ice_pf_fwlog_update_module()
> ice: introduce ice_fwlog structure
> ice: add pdev into fwlog structure and use it for logging
> ice: allow calling custom send function in fwlog
> ice: move out debugfs init from fwlog
> ice: check for PF number outside the fwlog code
nit: I think that patch 8/15 updates ice_fwlog_init()
such that it begins with a blank line. I would delete it.
> ice: drop driver specific structure from fwlog code
> libie, ice: move fwlog admin queue to libie
> ice: move debugfs code to fwlog
> ice: prepare for moving file to libie
> ice: reregister fwlog after driver reinit
> ice, libie: move fwlog code to libie
> ixgbe: fwlog support for e610
...
The nit above notwithstanding, this looks good to me.
Please feel free to add:
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-08-26 13:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 4:23 [PATCH iwl-next v2 00/15] Fwlog support in ixgbe Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 01/15] ice: make fwlog functions static Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 02/15] ice: move get_fwlog_data() to fwlog file Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 03/15] ice: drop ice_pf_fwlog_update_module() Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 04/15] ice: introduce ice_fwlog structure Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 05/15] ice: add pdev into fwlog structure and use it for logging Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 06/15] ice: allow calling custom send function in fwlog Michal Swiatkowski
2025-09-04 4:01 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 07/15] ice: move out debugfs init from fwlog Michal Swiatkowski
2025-09-04 4:02 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 08/15] ice: check for PF number outside the fwlog code Michal Swiatkowski
2025-09-04 4:03 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 09/15] ice: drop driver specific structure from " Michal Swiatkowski
2025-09-04 4:05 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 10/15] libie, ice: move fwlog admin queue to libie Michal Swiatkowski
2025-09-04 4:08 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 11/15] ice: move debugfs code to fwlog Michal Swiatkowski
2025-08-12 4:23 ` [PATCH iwl-next v2 12/15] ice: prepare for moving file to libie Michal Swiatkowski
2025-09-04 4:08 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 13/15] ice: reregister fwlog after driver reinit Michal Swiatkowski
2025-09-04 4:09 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 14/15] ice, libie: move fwlog code to libie Michal Swiatkowski
2025-09-04 4:10 ` [Intel-wired-lan] " Rinitha, SX
2025-08-12 4:23 ` [PATCH iwl-next v2 15/15] ixgbe: fwlog support for e610 Michal Swiatkowski
2025-09-05 3:43 ` [Intel-wired-lan] " Rinitha, SX
2025-08-26 13:48 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826134851.GA5892@horms.kernel.org \
--to=horms@kernel.org \
--cc=dawid.osuchowski@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).