From: Simon Horman <horms@kernel.org>
To: Emil Tantilov <emil.s.tantilov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Aleksandr.Loktionov@intel.com, przemyslaw.kitszel@intel.com,
anthony.l.nguyen@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, decot@google.com, willemb@google.com,
joshua.a.hay@intel.com, madhu.chittim@intel.com
Subject: Re: [PATCH iwl-net 1/2] idpf: convert vport state to bitmap
Date: Wed, 27 Aug 2025 15:19:46 +0100 [thread overview]
Message-ID: <20250827141946.GC5652@horms.kernel.org> (raw)
In-Reply-To: <20250822035248.22969-2-emil.s.tantilov@intel.com>
On Thu, Aug 21, 2025 at 08:52:47PM -0700, Emil Tantilov wrote:
> Convert vport state to a bitmap and remove the DOWN state which is
> redundant in the existing logic. There are no functional changes aside
> from the use of bitwise operations when setting and checking the states.
> Removed the double underscore to be consistent with the naming of other
> bitmaps in the header and renamed current_state to vport_is_up to match
> the meaning of the new variable.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Chittim Madhu <madhu.chittim@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-08-27 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 3:52 [PATCH iwl-net 0/2] idpf: Fix vport state handling Emil Tantilov
2025-08-22 3:52 ` [PATCH iwl-net 1/2] idpf: convert vport state to bitmap Emil Tantilov
2025-08-27 14:19 ` Simon Horman [this message]
2025-09-05 21:25 ` [Intel-wired-lan] " Salin, Samuel
2025-08-22 3:52 ` [PATCH iwl-net 2/2] idpf: fix possible race in idpf_vport_stop() Emil Tantilov
2025-08-27 14:20 ` Simon Horman
2025-09-05 21:25 ` [Intel-wired-lan] " Salin, Samuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827141946.GC5652@horms.kernel.org \
--to=horms@kernel.org \
--cc=Aleksandr.Loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).