From: Jakub Kicinski <kuba@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <Parthiban.Veerasooran@microchip.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] net: phy: micrel: Add PTP support for lan8842
Date: Wed, 27 Aug 2025 17:47:20 -0700 [thread overview]
Message-ID: <20250827174720.7b6406a1@kernel.org> (raw)
In-Reply-To: <20250826071100.334375-3-horatiu.vultur@microchip.com>
On Tue, 26 Aug 2025 09:11:00 +0200 Horatiu Vultur wrote:
> +#define LAN8842_STRAP_REG_PHYADDR_MASK GENMASK(4, 0)
> + addr = lanphy_read_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
> + LAN8842_STRAP_REG);
> + addr &= LAN8842_STRAP_REG_PHYADDR_MASK;
> + if (addr < 0)
> + return addr;
Did you mean to mask the value after the check if it's negative?
next prev parent reply other threads:[~2025-08-28 0:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 7:10 [PATCH net-next v3 0/2] net: phy: micrel: Add PTP support for lan8842 Horatiu Vultur
2025-08-26 7:10 ` [PATCH net-next v3 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe_once Horatiu Vultur
2025-08-28 0:49 ` Jakub Kicinski
2025-08-28 6:44 ` Horatiu Vultur
2025-08-26 7:11 ` [PATCH net-next v3 2/2] net: phy: micrel: Add PTP support for lan8842 Horatiu Vultur
2025-08-28 0:47 ` Jakub Kicinski [this message]
2025-08-28 6:43 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827174720.7b6406a1@kernel.org \
--to=kuba@kernel.org \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).