[PATCH] net/core: Replace offensive comment in skbuff.c

[PATCH] net/core: Replace offensive comment in skbuff.c

[mysteryli]

From: “mystery” <929916200@qq.com>

The original comment contained profanity to express the frustration of
dealing with a complex and resource-constrained code path. While the
sentiment is understandable, the language is unprofessional and
unnecessary.
Replace it with a more neutral and descriptive comment that maintains
the original technical context and conveys the difficulty of the
situation without the use of offensive language.

Signed-off-by: “mystery” <929916200@qq.com>
---
 net/core/skbuff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ee0274417948..202c25a01f22 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -5333,7 +5333,7 @@ int skb_cow_data(struct sk_buff *skb, int tailbits, struct sk_buff **trailer)
 		    skb_has_frag_list(skb1)) {
 			struct sk_buff *skb2;
 
-			/* Fuck, we are miserable poor guys... */
+			/* This is a painfully difficult situation with limited resources... */
 			if (ntail == 0)
 				skb2 = skb_copy(skb1, GFP_ATOMIC);
 			else
-- 
2.25.1

Re: [PATCH] net/core: Replace offensive comment in skbuff.c

[Andrew Lunn]

On Thu, Aug 28, 2025 at 04:42:53PM +0800, mysteryli wrote:
> From: “mystery” <929916200@qq.com>
> 
> The original comment contained profanity to express the frustration of
> dealing with a complex and resource-constrained code path. While the
> sentiment is understandable, the language is unprofessional and
> unnecessary.
> Replace it with a more neutral and descriptive comment that maintains
> the original technical context and conveys the difficulty of the
> situation without the use of offensive language.
> 
> Signed-off-by: “mystery” <929916200@qq.com>

Sorry, but this signed-off is not valid:

https://docs.kernel.org/process/submitting-patches.html

says:

Signed-off-by: Random J Developer <random@developer.example.org>

using a known identity (sorry, no anonymous contributions.)

Please resubmit using a real identity. Please also take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html


    Andrew

---
pw-bot: cr

Re: [PATCH] net/core: Replace offensive comment in skbuff.c

[Alexander Lobakin]

From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 28 Aug 2025 14:36:40 +0200

> On Thu, Aug 28, 2025 at 04:42:53PM +0800, mysteryli wrote:
>> From: “mystery” <929916200@qq.com>
>>
>> The original comment contained profanity to express the frustration of
>> dealing with a complex and resource-constrained code path. While the
>> sentiment is understandable, the language is unprofessional and
>> unnecessary.
>> Replace it with a more neutral and descriptive comment that maintains
>> the original technical context and conveys the difficulty of the
>> situation without the use of offensive language.
>>
>> Signed-off-by: “mystery” <929916200@qq.com>
> 
> Sorry, but this signed-off is not valid:
> 
> https://docs.kernel.org/process/submitting-patches.html
> 
> says:
> 
> Signed-off-by: Random J Developer <random@developer.example.org>
> 
> using a known identity (sorry, no anonymous contributions.)
> 
> Please resubmit using a real identity. Please also take a read of:
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Should we consider applying such patches at all? There are tons of such
comments, mostly in old code, while I highly doubt it may "offense" anyone.

> 
> 
>     Andrew

Thanks,
Olek