From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34272459E1 for ; Thu, 28 Aug 2025 08:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756370810; cv=none; b=pdySjuYBFZ7QCHPQNRw/26U9MZJrrmprZxo6+Ofco/d3zRed4EpiYn4Fs7uEG+iId3shBnY2S/tV1RYTy/DMsCD6nN8g9r/uhhm5X0b5pWv4vNE+esyLXF23D3lMhMJtT5/e54zAaqqnVj8nSBztyLmVh0Ws8S3Mj5hGXz7poCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756370810; c=relaxed/simple; bh=de2J3MJTaqYoEKquhyWV2Kxi2khjcmqfXABnAiwZOQo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EJv1gIV1nahfFNgAGpQvD3j+4n54iYYxQsSo4e55Oe30UjSLf4bcSFHY3N5VL2Aae38hUKSH3pVWWYjTLJlhncBuzQUw9y+IkdRlNDp0OVII8o49iBqH8pO4vm7x+L4C9l2v0xE4cAJNOrww6UVNRy4DGacbXM2ANTciZgo6yL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=bTpvSap6; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="bTpvSap6" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id EB3B51A0E47; Thu, 28 Aug 2025 08:46:38 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C49D160303; Thu, 28 Aug 2025 08:46:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 494A61C228428; Thu, 28 Aug 2025 10:46:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1756370798; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=fcQ9JtxCmzdFu9rK24Fv5CgRvuqX3Rs7LR5peXvP4UY=; b=bTpvSap6WG8UAFepu/5oFZ8X+VsjtKBuj5bDxTx2AyqMNuF0HqLVu93q2tlXWAbFxHA5M8 4FYeC5Alhs+RIusSLHDmKfLcG4jMhNkJPf/R+Aw1Dcl+b0ghdbIQtF1mlpd4Bxy/YzdM1Q t0DYbZJlMzSCrTtcz4SH6PY9nTZVjW/O0vWb2mNJ0cqz7Nj74zrj54sT5rd3QtVBcL/FDF TrYTOeYuwG03plHjGPTZC18loxqrEYA2ZFK0nRl0ynDnopidcq524HhdbXEvTlt5wb/fb1 /4ujEeXVNX88OcWqb/rteCsHOhZu0aKjFwU9qBYzPPRKC6uBQTW/XwTogJQVNw== Date: Thu, 28 Aug 2025 10:46:12 +0200 From: Kory Maincent To: Jakub Kicinski Cc: Oleksij Rempel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , kernel@pengutronix.de, Dent Project , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Chevallier Subject: Re: [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup Message-ID: <20250828104612.6b47301b@kmaincent-XPS-13-7390> In-Reply-To: <20250825151001.38af758c@kernel.org> References: <20250822-feature_poe_permanent_conf-v1-0-dcd41290254d@bootlin.com> <20250822-feature_poe_permanent_conf-v1-1-dcd41290254d@bootlin.com> <20250825151001.38af758c@kernel.org> Organization: bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Le Mon, 25 Aug 2025 15:10:01 -0700, Jakub Kicinski a =C3=A9crit : > On Fri, 22 Aug 2025 17:37:01 +0200 Kory Maincent wrote: > > manager =3D kcalloc(PD692X0_MAX_MANAGERS, sizeof(*manager), > > GFP_KERNEL); if (!manager) > > return -ENOMEM; > > =20 > > + port_matrix =3D devm_kcalloc(&priv->client->dev, PD692X0_MAX_PIS, > > + sizeof(*port_matrix), GFP_KERNEL); > > + if (!port_matrix) > > + return -ENOMEM; =20 >=20 > Leaking manager.. I don't think so, as manager is declared like the following it should not. struct pd692x0_manager *manager __free(kfree) =3D NULL; --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com