From: Konrad Leszczynski <konrad.leszczynski@intel.com>
To: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
cezary.rojewski@intel.com, sebastian.basierski@intel.com,
Piotr Warpechowski <piotr.warpechowski@intel.com>,
Karol Jurczenia <karol.jurczenia@intel.com>,
Konrad Leszczynski <konrad.leszczynski@intel.com>
Subject: [PATCH net-next 3/4] net: stmmac: enhance VLAN protocol detection for GRO
Date: Thu, 28 Aug 2025 16:45:57 +0200 [thread overview]
Message-ID: <20250828144558.304304-4-konrad.leszczynski@intel.com> (raw)
In-Reply-To: <20250828144558.304304-1-konrad.leszczynski@intel.com>
From: Piotr Warpechowski <piotr.warpechowski@intel.com>
Enhance protocol extraction in stmmac_has_ip_ethertype() by introducing
MAC offset parameter and changing:
__vlan_get_protocol() -> __vlan_get_protocol_offset()
Add correct header length for VLAN tags, which enable Generic Receive
Offload (GRO) in VLAN.
Co-developed-by: Karol Jurczenia <karol.jurczenia@intel.com>
Signed-off-by: Karol Jurczenia <karol.jurczenia@intel.com>
Reviewed-by: Sebastian Basierski <sebastian.basierski@intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Piotr Warpechowski <piotr.warpechowski@intel.com>
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 8977e5aebc71..630ffb8dd0c3 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4590,13 +4590,14 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
*/
static bool stmmac_has_ip_ethertype(struct sk_buff *skb)
{
- int depth = 0;
+ int depth = 0, hlen;
__be16 proto;
- proto = __vlan_get_protocol(skb, eth_header_parse_protocol(skb),
- &depth);
+ proto = __vlan_get_protocol_offset(skb, skb->protocol,
+ skb_mac_offset(skb), &depth);
+ hlen = eth_type_vlan(skb->protocol) ? VLAN_ETH_HLEN : ETH_HLEN;
- return (depth <= ETH_HLEN) &&
+ return (depth <= hlen) &&
(proto == htons(ETH_P_IP) || proto == htons(ETH_P_IPV6));
}
--
2.34.1
next prev parent reply other threads:[~2025-08-28 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 14:45 [PATCH net-next 0/4] net: stmmac: new features Konrad Leszczynski
2025-08-28 14:45 ` [PATCH net-next 1/4] net: stmmac: enable ARP Offload on mac_link_up() Konrad Leszczynski
2025-08-28 14:45 ` [PATCH net-next 2/4] net: stmmac: set TE/RE bits for ARP Offload when interface down Konrad Leszczynski
2025-08-28 14:45 ` Konrad Leszczynski [this message]
2025-08-28 14:45 ` [PATCH net-next 4/4] net: stmmac: add TC flower filter support for IP EtherType Konrad Leszczynski
2025-08-29 21:23 ` [PATCH net-next 0/4] net: stmmac: new features Jacob Keller
2025-08-30 2:46 ` Joseph Steel
2025-09-02 21:02 ` Jacob Keller
2025-09-02 21:17 ` Andrew Lunn
2025-09-03 17:01 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828144558.304304-4-konrad.leszczynski@intel.com \
--to=konrad.leszczynski@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=karol.jurczenia@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.warpechowski@intel.com \
--cc=sebastian.basierski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).