From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, almasrymina@google.com,
tariqt@nvidia.com, dtatulea@nvidia.com, hawk@kernel.org,
ilias.apalodimas@linaro.org, alexanderduyck@fb.com,
sdf@fomichev.me, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 00/14] eth: fbnic: support queue API and zero-copy Rx
Date: Thu, 28 Aug 2025 18:22:50 -0700 [thread overview]
Message-ID: <20250829012304.4146195-1-kuba@kernel.org> (raw)
Add support for queue API to fbnic, enable zero-copy Rx.
Patch 10 is likely of most interest as it adds a new core helper
(and touches mlx5). The rest of the patches are fbnic-specific
(and relatively boring).
Patches 1-3 reshuffle the Rx init/allocation path to better
align structures and functions which operate on them. Notably
patch 1 moves the page pool pointer to the queue struct (from NAPI).
Patch 4 converts the driver to use netmem_ref. The driver has
separate and explicit buffer queue for scatter / payloads, so only
references to those are converted.
Next 5 patches are more boring code shifts.
Patch 11 adds unreadable memory support to page pool allocation.
Patch 14 finally adds the support for queue API.
v2:
- rework patch 10
- update commit message in patch 11
v1: https://lore.kernel.org/20250820025704.166248-1-kuba@kernel.org
Jakub Kicinski (14):
eth: fbnic: move page pool pointer from NAPI to the ring struct
eth: fbnic: move xdp_rxq_info_reg() to resource alloc
eth: fbnic: move page pool alloc to fbnic_alloc_rx_qt_resources()
eth: fbnic: use netmem_ref where applicable
eth: fbnic: request ops lock
eth: fbnic: split fbnic_disable()
eth: fbnic: split fbnic_flush()
eth: fbnic: split fbnic_enable()
eth: fbnic: split fbnic_fill()
net: add helper to pre-check if PP for an Rx queue will be unreadable
eth: fbnic: allocate unreadable page pool for the payloads
eth: fbnic: defer page pool recycling activation to queue start
eth: fbnic: don't pass NAPI into pp alloc
eth: fbnic: support queue ops / zero-copy Rx
drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 20 +-
include/net/netdev_queues.h | 2 +
include/net/page_pool/helpers.h | 12 +
.../net/ethernet/mellanox/mlx5/core/en_main.c | 9 +-
.../net/ethernet/meta/fbnic/fbnic_netdev.c | 1 +
drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 9 +-
drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 621 ++++++++++++------
net/core/netdev_rx_queue.c | 9 +
8 files changed, 454 insertions(+), 229 deletions(-)
--
2.51.0
next reply other threads:[~2025-08-29 1:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 1:22 Jakub Kicinski [this message]
2025-08-29 1:22 ` [PATCH net-next v2 01/14] eth: fbnic: move page pool pointer from NAPI to the ring struct Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 02/14] eth: fbnic: move xdp_rxq_info_reg() to resource alloc Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 03/14] eth: fbnic: move page pool alloc to fbnic_alloc_rx_qt_resources() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 04/14] eth: fbnic: use netmem_ref where applicable Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 05/14] eth: fbnic: request ops lock Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 06/14] eth: fbnic: split fbnic_disable() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 07/14] eth: fbnic: split fbnic_flush() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 08/14] eth: fbnic: split fbnic_enable() Jakub Kicinski
2025-08-29 1:22 ` [PATCH net-next v2 09/14] eth: fbnic: split fbnic_fill() Jakub Kicinski
2025-08-29 1:23 ` [PATCH net-next v2 10/14] net: add helper to pre-check if PP for an Rx queue will be unreadable Jakub Kicinski
2025-08-29 21:56 ` Mina Almasry
2025-08-29 1:23 ` [PATCH net-next v2 11/14] eth: fbnic: allocate unreadable page pool for the payloads Jakub Kicinski
2025-08-29 1:23 ` [PATCH net-next v2 12/14] eth: fbnic: defer page pool recycling activation to queue start Jakub Kicinski
2025-08-29 21:57 ` Mina Almasry
2025-08-29 1:23 ` [PATCH net-next v2 13/14] eth: fbnic: don't pass NAPI into pp alloc Jakub Kicinski
2025-08-29 1:23 ` [PATCH net-next v2 14/14] eth: fbnic: support queue ops / zero-copy Rx Jakub Kicinski
2025-08-29 22:09 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829012304.4146195-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).