* [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI
@ 2025-08-29 6:48 Kohei Enju
2025-08-29 15:37 ` Samiullah Khawaja
2025-09-01 20:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Kohei Enju @ 2025-08-29 6:48 UTC (permalink / raw)
To: netdev, linux-doc
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Jonathan Corbet, Kohei Enju, Samiullah Khawaja
Commit 2677010e7793 ("Add support to set NAPI threaded for individual
NAPI") introduced threaded NAPI configuration per individual NAPI
instance, however obsolete description that threaded NAPI is per device
has remained.
Remove the old description and clarify that only NAPI instances running
in threaded mode spawn kernel threads by changing "Each NAPI instance"
to "Each threaded NAPI instance".
Cc: Samiullah Khawaja <skhawaja@google.com>
Signed-off-by: Kohei Enju <enjuk@amazon.com>
---
Documentation/networking/napi.rst | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
index a15754adb041..7dd60366f4ff 100644
--- a/Documentation/networking/napi.rst
+++ b/Documentation/networking/napi.rst
@@ -433,9 +433,8 @@ Threaded NAPI
Threaded NAPI is an operating mode that uses dedicated kernel
threads rather than software IRQ context for NAPI processing.
-The configuration is per netdevice and will affect all
-NAPI instances of that device. Each NAPI instance will spawn a separate
-thread (called ``napi/${ifc-name}-${napi-id}``).
+Each threaded NAPI instance will spawn a separate thread
+(called ``napi/${ifc-name}-${napi-id}``).
It is recommended to pin each kernel thread to a single CPU, the same
CPU as the CPU which services the interrupt. Note that the mapping
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI
2025-08-29 6:48 [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI Kohei Enju
@ 2025-08-29 15:37 ` Samiullah Khawaja
2025-09-01 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Samiullah Khawaja @ 2025-08-29 15:37 UTC (permalink / raw)
To: Kohei Enju
Cc: netdev, linux-doc, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, Jonathan Corbet
On Thu, Aug 28, 2025 at 11:49 PM Kohei Enju <enjuk@amazon.com> wrote:
>
> Commit 2677010e7793 ("Add support to set NAPI threaded for individual
> NAPI") introduced threaded NAPI configuration per individual NAPI
> instance, however obsolete description that threaded NAPI is per device
> has remained.
>
> Remove the old description and clarify that only NAPI instances running
> in threaded mode spawn kernel threads by changing "Each NAPI instance"
> to "Each threaded NAPI instance".
>
> Cc: Samiullah Khawaja <skhawaja@google.com>
> Signed-off-by: Kohei Enju <enjuk@amazon.com>
> ---
> Documentation/networking/napi.rst | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index a15754adb041..7dd60366f4ff 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -433,9 +433,8 @@ Threaded NAPI
>
> Threaded NAPI is an operating mode that uses dedicated kernel
> threads rather than software IRQ context for NAPI processing.
> -The configuration is per netdevice and will affect all
> -NAPI instances of that device. Each NAPI instance will spawn a separate
> -thread (called ``napi/${ifc-name}-${napi-id}``).
> +Each threaded NAPI instance will spawn a separate thread
> +(called ``napi/${ifc-name}-${napi-id}``).
>
> It is recommended to pin each kernel thread to a single CPU, the same
> CPU as the CPU which services the interrupt. Note that the mapping
> --
> 2.48.1
>
>
Reviewed-by: Samiullah Khawaja <skhawaja@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI
2025-08-29 6:48 [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI Kohei Enju
2025-08-29 15:37 ` Samiullah Khawaja
@ 2025-09-01 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-01 20:20 UTC (permalink / raw)
To: Kohei Enju
Cc: netdev, linux-doc, davem, edumazet, kuba, pabeni, horms, corbet,
skhawaja
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 29 Aug 2025 15:48:42 +0900 you wrote:
> Commit 2677010e7793 ("Add support to set NAPI threaded for individual
> NAPI") introduced threaded NAPI configuration per individual NAPI
> instance, however obsolete description that threaded NAPI is per device
> has remained.
>
> Remove the old description and clarify that only NAPI instances running
> in threaded mode spawn kernel threads by changing "Each NAPI instance"
> to "Each threaded NAPI instance".
>
> [...]
Here is the summary with links:
- [v1,net-next] docs: remove obsolete description about threaded NAPI
https://git.kernel.org/netdev/net/c/b434a3772dca
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-01 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-29 6:48 [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI Kohei Enju
2025-08-29 15:37 ` Samiullah Khawaja
2025-09-01 20:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).