From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9820325DCF0 for ; Fri, 29 Aug 2025 08:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756456006; cv=none; b=W6HqlKXxmPcdnhrgh252ft8Xic+qnzgQsMyDeFInkWRI0mj+A8NSy/yN3nAuUSn0A2qZg6lSzY9+Trowoi3AzwZq0nZF9vULnq9NXgQ1pl/CjiqtrOxNjlOTUMV/9mtrnOlBhN6hPcs5GETrKP9gBQf6dWjWqBqs78vKT/Pu4NM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756456006; c=relaxed/simple; bh=7qLeM+kxTRxbJYzKciRd095XlXC2ywCb1PAwpEcIAIQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bUsX3dh8sh76glAUrhuP9rjN6zqMUXhPzIAOUHvxzRN2SlcSAm8wsy2KE4CfC4ounUauAMJWWZI/vV665580xjGOF5am5QbRmBBmL1soYd7PEJoaiDPGPh9MRCcw+2ujJdO7zpCh/f8kGIhUEuw52D+wkH4ozGXMAxLiesKW2sE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=I2yuhlbI; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="I2yuhlbI" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 0E0F0C653F7; Fri, 29 Aug 2025 08:26:28 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 69D60606B9; Fri, 29 Aug 2025 08:26:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 489E41C22DB07; Fri, 29 Aug 2025 10:26:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1756456001; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=qcdtZuoiQD8z2g6YK6ro+/M/nM5t+ResA19W1UFPmC8=; b=I2yuhlbIdJhY58deLkKVTIrANBMDvHgpen9qkOwAhguqx+0xdP+m1pVape31vNO9o/z6Pb VdltX5Yq1heXXt48FY3x0+7sZk2U3DE8lnkCC1ozU7wCQdJMmmmoDIqCTtZa+YYmWa8XV0 2Y2W8LqSPEVTzGtt6y+6qfcyHvJaitOnDUVjOPcl53DkQx4SEQyts0Xsilep02Xgoa/F/t o6L9IHaAPQq8+P1d3S0v2JZcILzSym/cIwIeXk4uJjJi6123/h5Evz1av0sqPoBUp/LpnC ReNyS1zRgqddoPcBfRl+pGXySzTpoyEJDrE+Nyk7cpEucM1drsZOUOrWSH3VdA== Date: Fri, 29 Aug 2025 10:26:24 +0200 From: Kory Maincent To: Jakub Kicinski Cc: Oleksij Rempel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , kernel@pengutronix.de, Dent Project , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Chevallier Subject: Re: [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup Message-ID: <20250829102624.1d959943@kmaincent-XPS-13-7390> In-Reply-To: <20250828151218.1c187938@kernel.org> References: <20250822-feature_poe_permanent_conf-v1-0-dcd41290254d@bootlin.com> <20250822-feature_poe_permanent_conf-v1-1-dcd41290254d@bootlin.com> <20250825151001.38af758c@kernel.org> <20250828104612.6b47301b@kmaincent-XPS-13-7390> <20250828151218.1c187938@kernel.org> Organization: bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On Thu, 28 Aug 2025 15:12:18 -0700 Jakub Kicinski wrote: > On Thu, 28 Aug 2025 10:46:12 +0200 Kory Maincent wrote: > > > On Fri, 22 Aug 2025 17:37:01 +0200 Kory Maincent wrote: =20 > [...] =20 > > >=20 > > > Leaking manager.. =20 > >=20 > > I don't think so, as manager is declared like the following it should n= ot. > > struct pd692x0_manager *manager __free(kfree) =3D NULL; =20 >=20 > Please consult documentation on the user of __free() within networking. Oh, I didn't know about this net policy. I didn't follow the maintainer-netdev doc changes. Maybe I should. Ok, I will add a patch to the series to remove the __free macro.=20 Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com